You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by sa...@apache.org on 2016/01/10 20:47:52 UTC
svn commit: r1723958 - in /lucene/dev/branches/lucene_solr_5_3: ./
dev-tools/ dev-tools/scripts/smokeTestRelease.py
Author: sarowe
Date: Sun Jan 10 19:47:52 2016
New Revision: 1723958
URL: http://svn.apache.org/viewvc?rev=1723958&view=rev
Log:
LUCENE-6955: The release smoke tester inappropriately requires back compat index testing for versions not less than the one being smoke tested (merged trunk r1723956)
Modified:
lucene/dev/branches/lucene_solr_5_3/ (props changed)
lucene/dev/branches/lucene_solr_5_3/dev-tools/ (props changed)
lucene/dev/branches/lucene_solr_5_3/dev-tools/scripts/smokeTestRelease.py
Modified: lucene/dev/branches/lucene_solr_5_3/dev-tools/scripts/smokeTestRelease.py
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_3/dev-tools/scripts/smokeTestRelease.py?rev=1723958&r1=1723957&r2=1723958&view=diff
==============================================================================
--- lucene/dev/branches/lucene_solr_5_3/dev-tools/scripts/smokeTestRelease.py (original)
+++ lucene/dev/branches/lucene_solr_5_3/dev-tools/scripts/smokeTestRelease.py Sun Jan 10 19:47:52 2016
@@ -759,7 +759,7 @@ def verifyUnpacked(java, project, artifa
if project == 'lucene' and isSrc:
print(' confirm all releases have coverage in TestBackwardsCompatibility')
- confirmAllReleasesAreTestedForBackCompat(unpackPath)
+ confirmAllReleasesAreTestedForBackCompat(version, unpackPath)
def testNotice(unpackPath):
@@ -1313,7 +1313,7 @@ def getAllLuceneReleases():
l.sort()
return l
-def confirmAllReleasesAreTestedForBackCompat(unpackPath):
+def confirmAllReleasesAreTestedForBackCompat(smokeVersion, unpackPath):
print(' find all past Lucene releases...')
allReleases = getAllLuceneReleases()
@@ -1373,9 +1373,15 @@ def confirmAllReleasesAreTestedForBackCo
notTested = []
for x in allReleases:
if x not in testedIndices:
- if '.'.join(str(y) for y in x) in ('1.4.3', '1.9.1', '2.3.1', '2.3.2'):
+ releaseVersion = '.'.join(str(y) for y in x)
+ if releaseVersion in ('1.4.3', '1.9.1', '2.3.1', '2.3.2'):
# Exempt the dark ages indices
continue
+ if x >= tuple(int(y) for y in smokeVersion.split('.')):
+ # Exempt versions not less than the one being smoke tested
+ print(' Backcompat testing not required for release %s because it\'s not less than %s'
+ % (releaseVersion, smokeVersion))
+ continue
notTested.append(x)
if len(notTested) > 0: