You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2025/09/12 17:44:03 UTC

[Impala-ASF-CR] IMPALA-14430: Move off org.codehaus.jackson

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23420


Change subject: IMPALA-14430: Move off org.codehaus.jackson
......................................................................

IMPALA-14430: Move off org.codehaus.jackson

Removes the last use of org.codehaus.jackson in favor of
com.fasterxml.jackson.

Change-Id: I3166061a16bdef1ab5936d6e69dc69404b3acee7
---
M fe/src/main/java/org/apache/impala/util/JMXJsonUtil.java
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/23420/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3166061a16bdef1ab5936d6e69dc69404b3acee7
Gerrit-Change-Number: 23420
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-14430: Move off org.codehaus.jackson

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23420 )

Change subject: IMPALA-14430: Move off org.codehaus.jackson
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20466/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3166061a16bdef1ab5936d6e69dc69404b3acee7
Gerrit-Change-Number: 23420
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 18:11:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14430: Move off org.codehaus.jackson

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23420 )

Change subject: IMPALA-14430: Move off org.codehaus.jackson
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3166061a16bdef1ab5936d6e69dc69404b3acee7
Gerrit-Change-Number: 23420
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 22:16:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14430: Move off org.codehaus.jackson

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23420 )

Change subject: IMPALA-14430: Move off org.codehaus.jackson
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12475/


-- 
To view, visit http://gerrit.cloudera.org:8080/23420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3166061a16bdef1ab5936d6e69dc69404b3acee7
Gerrit-Change-Number: 23420
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sat, 13 Sep 2025 03:35:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14430: Move off org.codehaus.jackson

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23420 )

Change subject: IMPALA-14430: Move off org.codehaus.jackson
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23420/1/fe/src/main/java/org/apache/impala/util/JMXJsonUtil.java
File fe/src/main/java/org/apache/impala/util/JMXJsonUtil.java:

http://gerrit.cloudera.org:8080/#/c/23420/1/fe/src/main/java/org/apache/impala/util/JMXJsonUtil.java@a21
PS1, Line 21: 
            : 
> Those conversions for testing are still relevant until we actually move to 
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/23420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3166061a16bdef1ab5936d6e69dc69404b3acee7
Gerrit-Change-Number: 23420
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 21:59:19 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14430: Move off org.codehaus.jackson

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23420 )

Change subject: IMPALA-14430: Move off org.codehaus.jackson
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12483/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/23420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3166061a16bdef1ab5936d6e69dc69404b3acee7
Gerrit-Change-Number: 23420
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Sep 2025 15:17:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14430: Move off org.codehaus.jackson

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23420 )

Change subject: IMPALA-14430: Move off org.codehaus.jackson
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23420/1/fe/src/main/java/org/apache/impala/util/JMXJsonUtil.java
File fe/src/main/java/org/apache/impala/util/JMXJsonUtil.java:

http://gerrit.cloudera.org:8080/#/c/23420/1/fe/src/main/java/org/apache/impala/util/JMXJsonUtil.java@a21
PS1, Line 21: 
            : 
> nit: There are some minor reference to org.codehaus.jackson in fe/src/test/
Those conversions for testing are still relevant until we actually move to a consistent version of Avro that doesn't use org.codehaus.



-- 
To view, visit http://gerrit.cloudera.org:8080/23420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3166061a16bdef1ab5936d6e69dc69404b3acee7
Gerrit-Change-Number: 23420
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 19:16:50 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14430: Move off org.codehaus.jackson

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23420 )

Change subject: IMPALA-14430: Move off org.codehaus.jackson
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12475/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/23420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3166061a16bdef1ab5936d6e69dc69404b3acee7
Gerrit-Change-Number: 23420
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 22:16:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14430: Move off org.codehaus.jackson

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23420 )

Change subject: IMPALA-14430: Move off org.codehaus.jackson
......................................................................


Patch Set 2:

> Patch Set 2: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12475/

Ran into two independent failures. Rerunning.


-- 
To view, visit http://gerrit.cloudera.org:8080/23420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3166061a16bdef1ab5936d6e69dc69404b3acee7
Gerrit-Change-Number: 23420
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Sep 2025 15:17:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14430: Move off org.codehaus.jackson

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23420 )

Change subject: IMPALA-14430: Move off org.codehaus.jackson
......................................................................

IMPALA-14430: Move off org.codehaus.jackson

Removes the last use of org.codehaus.jackson in favor of
com.fasterxml.jackson.

Change-Id: I3166061a16bdef1ab5936d6e69dc69404b3acee7
Reviewed-on: http://gerrit.cloudera.org:8080/23420
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/util/JMXJsonUtil.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3166061a16bdef1ab5936d6e69dc69404b3acee7
Gerrit-Change-Number: 23420
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14430: Move off org.codehaus.jackson

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23420 )

Change subject: IMPALA-14430: Move off org.codehaus.jackson
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3166061a16bdef1ab5936d6e69dc69404b3acee7
Gerrit-Change-Number: 23420
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Sep 2025 20:38:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14430: Move off org.codehaus.jackson

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has removed a vote on this change.

Change subject: IMPALA-14430: Move off org.codehaus.jackson
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/23420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3166061a16bdef1ab5936d6e69dc69404b3acee7
Gerrit-Change-Number: 23420
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14430: Move off org.codehaus.jackson

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23420 )

Change subject: IMPALA-14430: Move off org.codehaus.jackson
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23420/1/fe/src/main/java/org/apache/impala/util/JMXJsonUtil.java
File fe/src/main/java/org/apache/impala/util/JMXJsonUtil.java:

http://gerrit.cloudera.org:8080/#/c/23420/1/fe/src/main/java/org/apache/impala/util/JMXJsonUtil.java@a21
PS1, Line 21: 
            : 
nit: There are some minor reference to org.codehaus.jackson in fe/src/test/java/org/apache/impala/common/FrontendTestBase.java
Does that need cleanup as well?



-- 
To view, visit http://gerrit.cloudera.org:8080/23420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3166061a16bdef1ab5936d6e69dc69404b3acee7
Gerrit-Change-Number: 23420
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 18:23:32 +0000
Gerrit-HasComments: Yes