You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by georgekankava <gi...@git.apache.org> on 2016/06/28 17:45:52 UTC
[GitHub] deltaspike pull request #55: squid:S2583 - Conditions should not uncondition...
GitHub user georgekankava opened a pull request:
https://github.com/apache/deltaspike/pull/55
squid:S2583 - Conditions should not unconditionally evaluate to 'TRUE' or to 'FALSE'
This pull request is focused on resolving occurrences of Sonar rule
squid:S2583 - Conditions should not unconditionally evaluate to 'TRUE' or to 'FALSE'.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S2583
Please let me know if you have any questions.
George Kankava
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DevFactory/deltaspike release/conditions-should-not-unconditionally-evaluate-to-TRUE-or-to-FALSE-fix-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/55.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #55
----
commit 439b6ace72224cca954d49cac06acedc19ed488b
Author: George Kankava <ge...@devfactory.com>
Date: 2016-06-28T17:40:34Z
squid:S2583 - Conditions should not unconditionally evaluate to 'TRUE' or to 'FALSE'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] deltaspike pull request #55: squid:S2583 - Conditions should not uncondition...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:
https://github.com/apache/deltaspike/pull/55#discussion_r69667867
--- Diff: deltaspike/modules/data/impl/src/main/java/org/apache/deltaspike/data/impl/handler/QueryHandler.java ---
@@ -154,10 +154,6 @@ public Object process(Object proxy, Method method, Object[] args) throws Throwab
catch (Exception e)
{
log.log(Level.FINEST, "Query execution error", e);
- if (queryContext != null)
--- End diff --
Everything else in this PR looks fine except this change. There is a chance that queryContext may be null here, its just not reported due to runtime exceptions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] deltaspike pull request #55: squid:S2583 - Conditions should not uncondition...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/55
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---