You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by km...@apache.org on 2008/01/21 04:27:28 UTC
svn commit: r613741 - in
/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src:
main/java/org/apache/cayenne/access/jdbc/
test/java/org/apache/cayenne/reflect/ test/java/org/apache/cayenne/xml/
Author: kmenard
Date: Sun Jan 20 19:27:26 2008
New Revision: 613741
URL: http://svn.apache.org/viewvc?rev=613741&view=rev
Log:
Replaced Boolean constructor calls valueOf much like we did with Integer.
Modified:
cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/access/jdbc/EJBQLConditionTranslator.java
cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/reflect/PropertyUtilsTest.java
cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/xml/TestObject.java
Modified: cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/access/jdbc/EJBQLConditionTranslator.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/access/jdbc/EJBQLConditionTranslator.java?rev=613741&r1=613740&r2=613741&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/access/jdbc/EJBQLConditionTranslator.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/access/jdbc/EJBQLConditionTranslator.java Sun Jan 20 19:27:26 2008
@@ -599,7 +599,7 @@
context.append("null");
}
else {
- Object value = new Boolean(expression.getText());
+ Object value = Boolean.valueOf(expression.getText());
String var = context.bindParameter(value);
context.append(" #bind($").append(var).append(" 'BOOLEAN')");
}
Modified: cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/reflect/PropertyUtilsTest.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/reflect/PropertyUtilsTest.java?rev=613741&r1=613740&r2=613741&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/reflect/PropertyUtilsTest.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/reflect/PropertyUtilsTest.java Sun Jan 20 19:27:26 2008
@@ -84,7 +84,7 @@
assertSame(o1.getNumberField(), PropertyUtils.getProperty(o1, "numberField"));
assertSame(o1.getObjectField(), PropertyUtils.getProperty(o1, "objectField"));
assertSame(o1.getStringField(), PropertyUtils.getProperty(o1, "stringField"));
- assertEquals(new Boolean(o1.isBooleanField()), PropertyUtils.getProperty(
+ assertEquals(Boolean.valueOf(o1.isBooleanField()), PropertyUtils.getProperty(
o1,
"booleanField"));
}
@@ -99,7 +99,7 @@
PropertyUtils.setProperty(o2, "numberField", o1.getNumberField());
PropertyUtils.setProperty(o2, "objectField", o1.getObjectField());
PropertyUtils.setProperty(o2, "stringField", o1.getStringField());
- PropertyUtils.setProperty(o2, "booleanField", new Boolean(o1.isBooleanField()));
+ PropertyUtils.setProperty(o2, "booleanField", Boolean.valueOf(o1.isBooleanField()));
}
public void testGetPropertyMap() {
Modified: cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/xml/TestObject.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/xml/TestObject.java?rev=613741&r1=613740&r2=613741&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/xml/TestObject.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/xml/TestObject.java Sun Jan 20 19:27:26 2008
@@ -122,7 +122,7 @@
encoder.encodeProperty("parent", parent);
encoder.encodeProperty("name", name);
encoder.encodeProperty("age", new Integer(age));
- encoder.encodeProperty("open", new Boolean(open));
+ encoder.encodeProperty("open", Boolean.valueOf(open));
encoder.encodeProperty("children", children);
}