You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/31 13:09:21 UTC
[GitHub] [shardingsphere] yx9o opened a new pull request, #23230: Refactor ifNotExists of CREATE DEFAULT SHADOW ALGORITHM.
yx9o opened a new pull request, #23230:
URL: https://github.com/apache/shardingsphere/pull/23230
For #22844 , refactor ifNotExists of CREATE DEFAULT SHADOW ALGORITHM.
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23230: Refactor ifNotExists of CREATE DEFAULT SHADOW ALGORITHM.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23230:
URL: https://github.com/apache/shardingsphere/pull/23230#issuecomment-1368216798
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23230?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23230](https://codecov.io/gh/apache/shardingsphere/pull/23230?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (20935e2) into [master](https://codecov.io/gh/apache/shardingsphere/commit/9a6812d4bdc7b808b5467e5c09111da048d8bdf1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a6812d) will **decrease** coverage by `0.00%`.
> The diff coverage is `52.63%`.
```diff
@@ Coverage Diff @@
## master #23230 +/- ##
============================================
- Coverage 49.76% 49.76% -0.01%
Complexity 2453 2453
============================================
Files 4021 4021
Lines 57535 57536 +1
Branches 9133 9132 -1
============================================
- Hits 28633 28631 -2
- Misses 26364 26368 +4
+ Partials 2538 2537 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../CreateDefaultShadowAlgorithmStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/23230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQ3JlYXRlRGVmYXVsdFNoYWRvd0FsZ29yaXRobVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `50.00% <52.63%> (-3.34%)` | :arrow_down: |
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/23230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| [.../PersonalIdentityNumberRandomReplaceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/23230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvbWFzay9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tYXNrL2FsZ29yaXRobS9yZXBsYWNlL1BlcnNvbmFsSWRlbnRpdHlOdW1iZXJSYW5kb21SZXBsYWNlQWxnb3JpdGhtLmphdmE=) | `80.00% <0.00%> (-0.96%)` | :arrow_down: |
| [...ontend/executor/ConnectionThreadExecutorGroup.java](https://codecov.io/gh/apache/shardingsphere/pull/23230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvZXhlY3V0b3IvQ29ubmVjdGlvblRocmVhZEV4ZWN1dG9yR3JvdXAuamF2YQ==) | `86.66% <0.00%> (+13.33%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #23230: Refactor ifNotExists of CREATE DEFAULT SHADOW ALGORITHM.
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #23230:
URL: https://github.com/apache/shardingsphere/pull/23230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org