You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/01/24 20:12:03 UTC
[GitHub] [mynewt-nimble] mlaz opened a new pull request #741: Set bleprph
main task stack size to 512.
mlaz opened a new pull request #741: Set bleprph main task stack size to 512.
URL: https://github.com/apache/mynewt-nimble/pull/741
When using mcumgr's image management uploads on this app at least 502 words would be needed for stack. This is a similar problem to the one described on https://github.com/apache/mynewt-mcumgr/pull/59 so I came up with a value slightly higher than what was measured.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] mlaz commented on issue #741: Set bleprph main task
stack size to 512.
Posted by GitBox <gi...@apache.org>.
mlaz commented on issue #741: Set bleprph main task stack size to 512.
URL: https://github.com/apache/mynewt-nimble/pull/741#issuecomment-578754523
> so this should be explained in commit message
Commit message updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on issue #741: Set
bleprph main task stack size to 512.
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on issue #741: Set bleprph main task stack size to 512.
URL: https://github.com/apache/mynewt-nimble/pull/741#issuecomment-578307942
so this should be explained in commit message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] vrahane commented on issue #741: Set bleprph main
task stack size to 512.
Posted by GitBox <gi...@apache.org>.
vrahane commented on issue #741: Set bleprph main task stack size to 512.
URL: https://github.com/apache/mynewt-nimble/pull/741#issuecomment-578305794
@andrzej-kaczmarek We figured out already :-) there was a related discussion on the mcumgr slack channel, so there is a 512 byte flat buffer which gets allocated on the stack for the upload request. we decided to keep the flat buf as it is on the stack since putting it in the bss or making it a global would be wasting memory all the time and mbufs would mean adding APIs for making the upload requests OS agnostic. You can follow the mcumgr slack channel for the discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on issue #741: Set
bleprph main task stack size to 512.
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on issue #741: Set bleprph main task stack size to 512.
URL: https://github.com/apache/mynewt-nimble/pull/741#issuecomment-578301114
would be actually better if someone check why mcumgr consumes so much stack instead of just increasing stack size...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] mlaz merged pull request #741: Set bleprph main
task stack size to 512.
Posted by GitBox <gi...@apache.org>.
mlaz merged pull request #741: Set bleprph main task stack size to 512.
URL: https://github.com/apache/mynewt-nimble/pull/741
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services