You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/20 12:09:39 UTC
[GitHub] [spark] bryanck opened a new pull request, #37950: [SPARK-40505][K8S] Remove min heap setting for executor in entrypoint.sh
bryanck opened a new pull request, #37950:
URL: https://github.com/apache/spark/pull/37950
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR removes the min heap setting (`-Xms`) from the JVM args when starting the executor process.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Removing the min heap setting is consistent with the settings for the YARN executor process and allows the JVM to reduce the heap when needed to reduce memory consumption.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
We have this change deployed in our production environment to solve for OOM kills we were experiencing when running in K8S but were not seeing when running in YARN.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bryanck commented on pull request #37950: [SPARK-40505][K8S] Remove min heap setting for executor in entrypoint.sh
Posted by GitBox <gi...@apache.org>.
bryanck commented on PR #37950:
URL: https://github.com/apache/spark/pull/37950#issuecomment-1256420693
I don't believe it is best practice to set a fixed JVM heap on k8s and not on YARN. If that is the case, I would be very interested in reading more about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #37950: [SPARK-40505][K8S] Remove min heap setting for executor in entrypoint.sh
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #37950:
URL: https://github.com/apache/spark/pull/37950#issuecomment-1256313145
You can propose to YARN committers as a YARN PR, but I believe we don't want to make any surprise to the existing YARN users when there is no issue there like you mentioned. Although consistency is good in general, there is a reason why we have separate resource manager modules like K8s, YARN, Mesos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bryanck commented on pull request #37950: [SPARK-40505][K8S] Remove min heap setting for executor in entrypoint.sh
Posted by GitBox <gi...@apache.org>.
bryanck commented on PR #37950:
URL: https://github.com/apache/spark/pull/37950#issuecomment-1256321893
I don't follow how a YARN PR will help? AFAIK, the executor heap is [set by Spark](https://github.com/apache/spark/blob/07061f1a07a96f59ae42c9df6110eb784d2f3dab/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnable.scala#L132)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #37950: [SPARK-40505][K8S] Remove min heap setting for executor in entrypoint.sh
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #37950: [SPARK-40505][K8S] Remove min heap setting for executor in entrypoint.sh
URL: https://github.com/apache/spark/pull/37950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #37950: [SPARK-40505][K8S] Remove min heap setting for executor in entrypoint.sh
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #37950:
URL: https://github.com/apache/spark/pull/37950#issuecomment-1256397614
I mean K8s module has been choosing the best practice in K8s control plane and I believe YARN module is the same situation I guess.
> You mentioned there is a reason for the different modules, can you explain the reason k8s is configured to use a fixed heap size and YARN does not?
I seems that you misunderstand. Your PR description claim like that, not me. This is what you wrote, `settings for the YARN executor process and allows the JVM to reduce the heap when needed to reduce memory consumption.`, in this PR description, isn't it?
> I don't follow how a YARN PR will help?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bryanck commented on pull request #37950: [SPARK-40505][K8S] Remove min heap setting for executor in entrypoint.sh
Posted by GitBox <gi...@apache.org>.
bryanck commented on PR #37950:
URL: https://github.com/apache/spark/pull/37950#issuecomment-1256316102
You mentioned there is a reason for the different modules, can you explain the reason k8s is configured to use a fixed heap size and YARN does not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #37950: [SPARK-40505][K8S] Remove min heap setting for executor in entrypoint.sh
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37950:
URL: https://github.com/apache/spark/pull/37950#issuecomment-1252898093
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bryanck commented on pull request #37950: [SPARK-40505][K8S] Remove min heap setting for executor in entrypoint.sh
Posted by GitBox <gi...@apache.org>.
bryanck commented on PR #37950:
URL: https://github.com/apache/spark/pull/37950#issuecomment-1256128312
Thanks for pointing out memory settings @dongjoon-hyun , the goal of this PR is to bring more consistent memory usage behavior between YARN and k8s rather than to solve for a specific use case. If the community has determined a fixed heap size is optimal, then that should be set for YARN as well, unless there is some reasoning for the difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #37950: [SPARK-40505][K8S] Remove min heap setting for executor in entrypoint.sh
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #37950:
URL: https://github.com/apache/spark/pull/37950#issuecomment-1256313494
Let me close this PR for now. We can continue our discussion on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org