You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/06/30 20:23:21 UTC
[kudu-CR] [monotime] deprecating MonoTime::Earliest()
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7347
Change subject: [monotime] deprecating MonoTime::Earliest()
......................................................................
[monotime] deprecating MonoTime::Earliest()
Deprecating MonoTime::Earliest() in favor of std::min().
This patch does not contain any functional changes.
Change-Id: Ib7a4fd7881834db632147ebfa1afc138d6432e26
---
M src/kudu/client/client-internal.cc
M src/kudu/client/master_rpc.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/scanner-internal.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tablet/tablet_mm_ops-test.cc
M src/kudu/util/monotime.h
7 files changed, 13 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/7347/1
--
To view, visit http://gerrit.cloudera.org:8080/7347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7a4fd7881834db632147ebfa1afc138d6432e26
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [monotime] deprecating MonoTime::Earliest()
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [monotime] deprecating MonoTime::Earliest()
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7a4fd7881834db632147ebfa1afc138d6432e26
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [monotime] deprecating MonoTime::Earliest()
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: [monotime] deprecating MonoTime::Earliest()
......................................................................
[monotime] deprecating MonoTime::Earliest()
Deprecating MonoTime::Earliest() in favor of std::min().
This patch does not contain any functional changes.
Change-Id: Ib7a4fd7881834db632147ebfa1afc138d6432e26
Reviewed-on: http://gerrit.cloudera.org:8080/7347
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/client/client-internal.cc
M src/kudu/client/master_rpc.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/scanner-internal.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tablet/tablet_mm_ops-test.cc
M src/kudu/util/monotime.h
7 files changed, 15 insertions(+), 12 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7a4fd7881834db632147ebfa1afc138d6432e26
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [monotime] deprecating MonoTime::Earliest()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7347
to look at the new patch set (#3).
Change subject: [monotime] deprecating MonoTime::Earliest()
......................................................................
[monotime] deprecating MonoTime::Earliest()
Deprecating MonoTime::Earliest() in favor of std::min().
This patch does not contain any functional changes.
Change-Id: Ib7a4fd7881834db632147ebfa1afc138d6432e26
---
M src/kudu/client/client-internal.cc
M src/kudu/client/master_rpc.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/scanner-internal.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tablet/tablet_mm_ops-test.cc
M src/kudu/util/monotime.h
7 files changed, 15 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/7347/3
--
To view, visit http://gerrit.cloudera.org:8080/7347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib7a4fd7881834db632147ebfa1afc138d6432e26
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [monotime] deprecating MonoTime::Earliest()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [monotime] deprecating MonoTime::Earliest()
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7347/1/src/kudu/client/client-internal.cc
File src/kudu/client/client-internal.cc:
Line 173: // TODO: KUDU-683 tracks cleanup for this.
> warning: missing username/bug in TODO [google-readability-todo]
Done
http://gerrit.cloudera.org:8080/#/c/7347/1/src/kudu/util/monotime.h
File src/kudu/util/monotime.h:
Line 24: #include <gtest/gtest_prod.h>
> warning: #includes are not sorted properly [llvm-include-order]
Done
PS1, Line 178: max
> min?
woops, my bad.
Sure -- it should be std::min()
--
To view, visit http://gerrit.cloudera.org:8080/7347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7a4fd7881834db632147ebfa1afc138d6432e26
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [monotime] deprecating MonoTime::Earliest()
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [monotime] deprecating MonoTime::Earliest()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7347/1/src/kudu/util/monotime.h
File src/kudu/util/monotime.h:
PS1, Line 178: max
min?
--
To view, visit http://gerrit.cloudera.org:8080/7347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7a4fd7881834db632147ebfa1afc138d6432e26
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [monotime] deprecating MonoTime::Earliest()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [monotime] deprecating MonoTime::Earliest()
......................................................................
[monotime] deprecating MonoTime::Earliest()
Deprecating MonoTime::Earliest() in favor of std::min().
This patch does not contain any functional changes.
Change-Id: Ib7a4fd7881834db632147ebfa1afc138d6432e26
---
M src/kudu/client/client-internal.cc
M src/kudu/client/master_rpc.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/scanner-internal.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tablet/tablet_mm_ops-test.cc
M src/kudu/util/monotime.h
7 files changed, 13 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/7347/2
--
To view, visit http://gerrit.cloudera.org:8080/7347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib7a4fd7881834db632147ebfa1afc138d6432e26
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>