You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by ga...@apache.org on 2026/07/20 02:45:00 UTC

(iceberg-cpp) branch main updated: ci: enable ASF Copilot code review (#833)

This is an automated email from the ASF dual-hosted git repository.

wgtmac pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-cpp.git


The following commit(s) were added to refs/heads/main by this push:
     new c904c247 ci: enable ASF Copilot code review (#833)
c904c247 is described below

commit c904c247b3ad3f984da316cd810ad40295eeb7cf
Author: Gang Wu <us...@gmail.com>
AuthorDate: Mon Jul 20 10:44:54 2026 +0800

    ci: enable ASF Copilot code review (#833)
    
    ### Rationale for this change
    
    GitHub Copilot code review may help provide preliminary feedback on pull
    requests and reduce reviewer load while keeping human maintainers
    responsible for final review decisions.
    
    ### What changes are included in this PR?
    
    - Enable ASF-managed GitHub Copilot code review in `.asf.yaml`
    - Disable automatic reviews for draft PRs
    - Enable automatic reviews on new pushes
    - Add Copilot review instructions to reduce noisy comments
    
    ### Are these changes tested?
    
    Yes. `.asf.yaml` was parsed successfully as YAML, and `git diff --check`
    passed.
    
    ### Are there any user-facing changes?
    
    No.
---
 .asf.yaml                         |  4 ++++
 .github/copilot-instructions.md   | 21 +++++++++++++++++++++
 dev/release/rat_exclude_files.txt |  1 +
 3 files changed, 26 insertions(+)

diff --git a/.asf.yaml b/.asf.yaml
index bff25db0..bdcb1e46 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -49,6 +49,10 @@ github:
     - manuzhang
   ghp_branch: gh-pages
   ghp_path: /
+  copilot_code_review:
+    enabled: true
+    review_drafts: false
+    review_on_push: true
 
 notifications:
   commits:      commits@iceberg.apache.org
diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md
new file mode 100644
index 00000000..e4a8ef02
--- /dev/null
+++ b/.github/copilot-instructions.md
@@ -0,0 +1,21 @@
+# Instructions
+
+## Code review
+
+You are a pragmatic senior developer. When reviewing pull requests,
+follow these rules to avoid noise and redundancy:
+
+- Be concise: Keep comments brief and to the point. Avoid
+  conversational filler or praising the code unless it's exceptional.
+- High-impact only: Focus on logic errors, security vulnerabilities,
+  performance bottlenecks, and breaking changes.
+- Skip the Obvious: Do not describe what the code is doing. Assume the
+  reader understands the code.
+- Ignore trivialities: Do not comment on minor style issues or things
+  that an automated linter should catch.
+- Single comment per issue: If the same pattern occurs multiple times,
+  mention it once and suggest a global fix instead of commenting on
+  every line.
+- First-time contributors: For users new to this repository,
+  explicitly instruct them to "Please check and address all review
+  comments in this PR."
diff --git a/dev/release/rat_exclude_files.txt b/dev/release/rat_exclude_files.txt
index b8a1c098..9afe473d 100644
--- a/dev/release/rat_exclude_files.txt
+++ b/dev/release/rat_exclude_files.txt
@@ -15,6 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
+.github/copilot-instructions.md
 .gitignore
 LICENSE
 NOTICE