You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Benedikt Ritter (Created) (JIRA)" <ji...@apache.org> on 2012/01/31 21:52:10 UTC
[jira] [Created] (SANDBOX-377) [BeanUtils2] Implement
invoke(Exact)Method(...) on DefaultBeanAccessor
[BeanUtils2] Implement invoke(Exact)Method(...) on DefaultBeanAccessor
----------------------------------------------------------------------
Key: SANDBOX-377
URL: https://issues.apache.org/jira/browse/SANDBOX-377
Project: Commons Sandbox
Issue Type: Improvement
Components: BeanUtils2
Affects Versions: Nightly Builds
Reporter: Benedikt Ritter
On DefaultBeanAccessor implement:
* invokeMethod( String methodName )
* invokeExactMethod( String methodName )
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SANDBOX-377) [BeanUtils2] Implement
invoke(Exact)Method(...) on DefaultBeanAccessor
Posted by "Simone Tripodi (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simone Tripodi resolved SANDBOX-377.
------------------------------------
Resolution: Fixed
Assignee: Simone Tripodi
Patch reviewed and applied, thanks, see [r1238950|http://svn.apache.org/viewvc?rev=1238950&view=rev]
As a side note: these auto-generated comments
{code}
+ /* (non-Javadoc)
+ * @see org.apache.commons.beanutils2.BeanAccessor#invokeMethod(java.lang.String)
+ */
{code}
are not good, please next time pay attention on putting the right Javadoc
> [BeanUtils2] Implement invoke(Exact)Method(...) on DefaultBeanAccessor
> ----------------------------------------------------------------------
>
> Key: SANDBOX-377
> URL: https://issues.apache.org/jira/browse/SANDBOX-377
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Assignee: Simone Tripodi
> Attachments: SANDBOX-377.txt
>
>
> On DefaultBeanAccessor implement:
> * invokeMethod( String methodName )
> * invokeExactMethod( String methodName )
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SANDBOX-377) [BeanUtils2] Implement
invoke(Exact)Method(...) on DefaultBeanAccessor
Posted by "Benedikt Ritter (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benedikt Ritter updated SANDBOX-377:
------------------------------------
Attachment: SANDBOX-377.txt
I've created a patch for this issue. Summary:
* implemented invokeMethod()
* implemented invokeExactMethod()
* implemented MethodsTestCase to test functionality
* Added JavaDoc to BeanAccessor
* Added JavaDoc to ArgumentsAccessor
> [BeanUtils2] Implement invoke(Exact)Method(...) on DefaultBeanAccessor
> ----------------------------------------------------------------------
>
> Key: SANDBOX-377
> URL: https://issues.apache.org/jira/browse/SANDBOX-377
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Attachments: SANDBOX-377.txt
>
>
> On DefaultBeanAccessor implement:
> * invokeMethod( String methodName )
> * invokeExactMethod( String methodName )
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-377) [BeanUtils2] Implement
invoke(Exact)Method(...) on DefaultBeanAccessor
Posted by "Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197648#comment-13197648 ]
Simone Tripodi commented on SANDBOX-377:
----------------------------------------
{quote}
Why are they not good?
{quote}
because they are non-javadoc Eclipse-related only, and not everybody uses Eclipse.
{quote}
My eclipse IDE wasn't able to retrieve the correct JavaDoc for methods with that sort of comment. So do we just add no JavaDoc to implementation classes? Or do we duplicate the JavaDoc from the interface? Or is something wrong with eclipse?
{quote}
Internal javadoc won't anyway exposed, so {{{@inheritDoc}}} is fine.
> [BeanUtils2] Implement invoke(Exact)Method(...) on DefaultBeanAccessor
> ----------------------------------------------------------------------
>
> Key: SANDBOX-377
> URL: https://issues.apache.org/jira/browse/SANDBOX-377
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Assignee: Simone Tripodi
> Attachments: SANDBOX-377.txt
>
>
> On DefaultBeanAccessor implement:
> * invokeMethod( String methodName )
> * invokeExactMethod( String methodName )
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-377) [BeanUtils2] Implement
invoke(Exact)Method(...) on DefaultBeanAccessor
Posted by "Benedikt Ritter (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197643#comment-13197643 ]
Benedikt Ritter commented on SANDBOX-377:
-----------------------------------------
Thanks for the commit and the feedback. I added the real description of the method to the interface. I thought these forward comments will do the job. Why are they not good?
I saw some methods where you added something like:
{code:java}
/**
* {@inheritDoc}
*/
{code}
My eclipse IDE wasn't able to retrieve the correct JavaDoc for methods with that sort of comment. So do we just add no JavaDoc to implementation classes? Or do we duplicate the JavaDoc from the interface? Or is something wrong with eclipse? ;)
TIA for the info and have a nice day!
Benedikt
> [BeanUtils2] Implement invoke(Exact)Method(...) on DefaultBeanAccessor
> ----------------------------------------------------------------------
>
> Key: SANDBOX-377
> URL: https://issues.apache.org/jira/browse/SANDBOX-377
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Assignee: Simone Tripodi
> Attachments: SANDBOX-377.txt
>
>
> On DefaultBeanAccessor implement:
> * invokeMethod( String methodName )
> * invokeExactMethod( String methodName )
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-377) [BeanUtils2] Implement
invoke(Exact)Method(...) on DefaultBeanAccessor
Posted by "Benedikt Ritter (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197672#comment-13197672 ]
Benedikt Ritter commented on SANDBOX-377:
-----------------------------------------
{quote}
because they are non-javadoc Eclipse-related only, and not everybody uses Eclipse.
{quote}
ouch... sorry about that. You will not see that again.
> [BeanUtils2] Implement invoke(Exact)Method(...) on DefaultBeanAccessor
> ----------------------------------------------------------------------
>
> Key: SANDBOX-377
> URL: https://issues.apache.org/jira/browse/SANDBOX-377
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Assignee: Simone Tripodi
> Attachments: SANDBOX-377.txt
>
>
> On DefaultBeanAccessor implement:
> * invokeMethod( String methodName )
> * invokeExactMethod( String methodName )
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira