You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Eugene Koontz (JIRA)" <ji...@apache.org> on 2012/07/05 20:04:35 UTC
[jira] [Created] (ZOOKEEPER-1503) remove redundant SASL
configuration code in SaslAuthTest and SaslAuthFailTest
Eugene Koontz created ZOOKEEPER-1503:
----------------------------------------
Summary: remove redundant SASL configuration code in SaslAuthTest and SaslAuthFailTest
Key: ZOOKEEPER-1503
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1503
Project: ZooKeeper
Issue Type: Improvement
Environment: In SaslAuthTest and SaslAuthFail test, we set the JAAS configuration twice with the same text string. This is confusing and redundant, since we need only set it once.
Reporter: Eugene Koontz
Assignee: Eugene Koontz
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1503) remove redundant SASL
configuration code in SaslAuthTest and SaslAuthFailTest
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407368#comment-13407368 ]
Hadoop QA commented on ZOOKEEPER-1503:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12535236/ZOOKEEPER-1503.patch
against trunk revision 1357711.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1123//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1123//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1123//console
This message is automatically generated.
> remove redundant SASL configuration code in SaslAuthTest and SaslAuthFailTest
> -----------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1503
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1503
> Project: ZooKeeper
> Issue Type: Improvement
> Environment: In SaslAuthTest and SaslAuthFail test, we set the JAAS configuration twice with the same text string. This is confusing and redundant, since we need only set it once.
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Attachments: ZOOKEEPER-1503.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1503) remove redundant JAAS
configuration code in SaslAuthTest and SaslAuthFailTest
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426898#comment-13426898 ]
Hudson commented on ZOOKEEPER-1503:
-----------------------------------
Integrated in ZooKeeper-trunk #1632 (See [https://builds.apache.org/job/ZooKeeper-trunk/1632/])
ZOOKEEPER-1503. remove redundant JAAS configuration code in SaslAuthTest and SaslAuthFailTest ((Eugene Koontz via phunt) (Revision 1368203)
Result = SUCCESS
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1368203
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/SaslAuthFailTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/SaslAuthTest.java
> remove redundant JAAS configuration code in SaslAuthTest and SaslAuthFailTest
> -----------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1503
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1503
> Project: ZooKeeper
> Issue Type: Improvement
> Environment: In SaslAuthTest and SaslAuthFail test, we set the JAAS configuration twice with the same text string. This is confusing and redundant, since we need only set it once.
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1503.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1503) remove redundant JAAS
configuration code in SaslAuthTest and SaslAuthFailTest
Posted by "Paolo Calabro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paolo Calabro updated ZOOKEEPER-1503:
-------------------------------------
Description: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1120//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
> remove redundant JAAS configuration code in SaslAuthTest and SaslAuthFailTest
> -----------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1503
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1503
> Project: ZooKeeper
> Issue Type: Improvement
> Environment: In SaslAuthTest and SaslAuthFail test, we set the JAAS configuration twice with the same text string. This is confusing and redundant, since we need only set it once.
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1503.patch
>
>
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1120//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1503) remove redundant JAAS
configuration code in SaslAuthTest and SaslAuthFailTest
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426858#comment-13426858 ]
Eugene Koontz commented on ZOOKEEPER-1503:
------------------------------------------
Sure thing, thanks for noticing that, Patrick.
https://issues.apache.org/jira/browse/ZOOKEEPER-1524
> remove redundant JAAS configuration code in SaslAuthTest and SaslAuthFailTest
> -----------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1503
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1503
> Project: ZooKeeper
> Issue Type: Improvement
> Environment: In SaslAuthTest and SaslAuthFail test, we set the JAAS configuration twice with the same text string. This is confusing and redundant, since we need only set it once.
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1503.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1503) remove redundant JAAS
configuration code in SaslAuthTest and SaslAuthFailTest
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated ZOOKEEPER-1503:
-------------------------------------
Summary: remove redundant JAAS configuration code in SaslAuthTest and SaslAuthFailTest (was: remove redundant SASL configuration code in SaslAuthTest and SaslAuthFailTest)
> remove redundant JAAS configuration code in SaslAuthTest and SaslAuthFailTest
> -----------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1503
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1503
> Project: ZooKeeper
> Issue Type: Improvement
> Environment: In SaslAuthTest and SaslAuthFail test, we set the JAAS configuration twice with the same text string. This is confusing and redundant, since we need only set it once.
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Attachments: ZOOKEEPER-1503.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1503) remove redundant SASL
configuration code in SaslAuthTest and SaslAuthFailTest
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated ZOOKEEPER-1503:
-------------------------------------
Attachment: ZOOKEEPER-1503.patch
> remove redundant SASL configuration code in SaslAuthTest and SaslAuthFailTest
> -----------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1503
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1503
> Project: ZooKeeper
> Issue Type: Improvement
> Environment: In SaslAuthTest and SaslAuthFail test, we set the JAAS configuration twice with the same text string. This is confusing and redundant, since we need only set it once.
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Attachments: ZOOKEEPER-1503.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1503) remove redundant JAAS
configuration code in SaslAuthTest and SaslAuthFailTest
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426834#comment-13426834 ]
Patrick Hunt commented on ZOOKEEPER-1503:
-----------------------------------------
Btw. I noticed that these tests are using a static block rather than using junit's before/after or beforeclass/afterclass. Eugene would you mind fixing this via a new jira? (unless there's a reason why you didn't use junit for this...)
> remove redundant JAAS configuration code in SaslAuthTest and SaslAuthFailTest
> -----------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1503
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1503
> Project: ZooKeeper
> Issue Type: Improvement
> Environment: In SaslAuthTest and SaslAuthFail test, we set the JAAS configuration twice with the same text string. This is confusing and redundant, since we need only set it once.
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1503.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira