You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/08/10 10:24:55 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #10562: fix(thumbnails): missing field, logging and new config var
dpgaspar opened a new pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#issuecomment-671471408
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=h1) Report
> Merging [#10562](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea0db0d1951039757a69d321ea920e0b6fdada67&el=desc) will **decrease** coverage by `0.22%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10562 +/- ##
==========================================
- Coverage 59.56% 59.34% -0.23%
==========================================
Files 767 767
Lines 36268 36282 +14
Branches 3426 3430 +4
==========================================
- Hits 21603 21530 -73
- Misses 14472 14559 +87
Partials 193 193
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.88% <ø> (-0.02%)` | :arrow_down: |
| #python | `59.02% <71.42%> (-0.35%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/tasks/thumbnails.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvdGh1bWJuYWlscy5weQ==) | `43.33% <0.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `74.16% <50.00%> (ø)` | |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `73.89% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.23% <100.00%> (ø)` | |
| [superset/utils/screenshots.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2NyZWVuc2hvdHMucHk=) | `29.41% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.47% <0.00%> (-1.81%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=footer). Last update [ea0db0d...b3ba2ab](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#issuecomment-671471408
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=h1) Report
> Merging [#10562](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/db88cec431bca04608c6580192714da03bed1e1b&el=desc) will **increase** coverage by `4.15%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10562 +/- ##
==========================================
+ Coverage 60.10% 64.26% +4.15%
==========================================
Files 775 775
Lines 36528 36529 +1
Branches 3459 3459
==========================================
+ Hits 21955 23474 +1519
+ Misses 14382 12943 -1439
+ Partials 191 112 -79
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.47% <ø> (?)` | |
| #javascript | `60.48% <ø> (ø)` | |
| #python | `59.85% <83.33%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/tasks/thumbnails.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvdGh1bWJuYWlscy5weQ==) | `43.33% <0.00%> (ø)` | |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `73.89% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.34% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `79.52% <100.00%> (ø)` | |
| [superset/utils/screenshots.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2NyZWVuc2hvdHMucHk=) | `36.36% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `77.92% <0.00%> (-0.44%)` | :arrow_down: |
| [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `81.77% <0.00%> (-0.41%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `56.98% <0.00%> (+1.07%)` | :arrow_up: |
| ... and [147 more](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=footer). Last update [db88cec...d453071](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#discussion_r468040415
##########
File path: superset/config.py
##########
@@ -797,6 +797,8 @@ class CeleryConfig: # pylint: disable=too-few-public-methods
# Any config options to be passed as-is to the webdriver
WEBDRIVER_CONFIGURATION: Dict[Any, Any] = {}
+# The webdriver to use supports "chrome" and "firefox"
+WEBDRIVER_TYPE = "firefox"
Review comment:
Maybe took it too far, but I actually removed it now. Tell me if it's ok by you @bkyryliuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#discussion_r468235626
##########
File path: superset/config.py
##########
@@ -790,7 +790,7 @@ class CeleryConfig: # pylint: disable=too-few-public-methods
# chrome:
# Requires: headless chrome
# Limitations: unable to generate screenshots of elements
-EMAIL_REPORTS_WEBDRIVER = "firefox"
+WEBDRIVER_TYPE = "firefox"
Review comment:
I would, but: https://github.com/apache/incubator-superset/blob/master/docs/installation.rst#email-reports
States that `firefox` is preferred, is it reasonable to change the default?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#issuecomment-671471408
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=h1) Report
> Merging [#10562](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/db88cec431bca04608c6580192714da03bed1e1b&el=desc) will **increase** coverage by `4.05%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10562 +/- ##
==========================================
+ Coverage 60.10% 64.15% +4.05%
==========================================
Files 775 775
Lines 36528 36529 +1
Branches 3459 3459
==========================================
+ Hits 21955 23436 +1481
+ Misses 14382 12978 -1404
+ Partials 191 115 -76
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.90% <ø> (?)` | |
| #javascript | `60.48% <ø> (ø)` | |
| #python | `59.85% <83.33%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/tasks/thumbnails.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvdGh1bWJuYWlscy5weQ==) | `43.33% <0.00%> (ø)` | |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `73.89% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.34% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `79.52% <100.00%> (ø)` | |
| [superset/utils/screenshots.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2NyZWVuc2hvdHMucHk=) | `36.36% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `77.92% <0.00%> (-0.44%)` | :arrow_down: |
| [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `81.77% <0.00%> (-0.41%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (+0.64%)` | :arrow_up: |
| ... and [144 more](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=footer). Last update [db88cec...d453071](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#issuecomment-671471408
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=h1) Report
> Merging [#10562](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea0db0d1951039757a69d321ea920e0b6fdada67&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10562 +/- ##
==========================================
- Coverage 59.56% 59.30% -0.27%
==========================================
Files 767 767
Lines 36268 36282 +14
Branches 3426 3430 +4
==========================================
- Hits 21603 21516 -87
- Misses 14472 14573 +101
Partials 193 193
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.88% <ø> (-0.02%)` | :arrow_down: |
| #python | `58.96% <71.42%> (-0.42%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/tasks/thumbnails.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvdGh1bWJuYWlscy5weQ==) | `43.33% <0.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `74.16% <50.00%> (ø)` | |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `73.89% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.23% <100.00%> (ø)` | |
| [superset/utils/screenshots.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2NyZWVuc2hvdHMucHk=) | `29.41% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.32% <0.00%> (-1.96%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [13 more](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=footer). Last update [ea0db0d...b3ba2ab](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#discussion_r468040415
##########
File path: superset/config.py
##########
@@ -797,6 +797,8 @@ class CeleryConfig: # pylint: disable=too-few-public-methods
# Any config options to be passed as-is to the webdriver
WEBDRIVER_CONFIGURATION: Dict[Any, Any] = {}
+# The webdriver to use supports "chrome" and "firefox"
+WEBDRIVER_TYPE = "firefox"
Review comment:
Maybe took it too far, but I actually removed it now. Tell me if it's ok by you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#discussion_r468224302
##########
File path: superset/config.py
##########
@@ -790,7 +790,7 @@ class CeleryConfig: # pylint: disable=too-few-public-methods
# chrome:
# Requires: headless chrome
# Limitations: unable to generate screenshots of elements
-EMAIL_REPORTS_WEBDRIVER = "firefox"
+WEBDRIVER_TYPE = "firefox"
Review comment:
optional: change default to `"chrome"` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#issuecomment-671471408
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=h1) Report
> Merging [#10562](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/db88cec431bca04608c6580192714da03bed1e1b&el=desc) will **increase** coverage by `3.97%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10562 +/- ##
==========================================
+ Coverage 60.10% 64.07% +3.97%
==========================================
Files 775 775
Lines 36528 36529 +1
Branches 3459 3459
==========================================
+ Hits 21955 23407 +1452
+ Misses 14382 13007 -1375
+ Partials 191 115 -76
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.13% <ø> (?)` | |
| #javascript | `60.48% <ø> (ø)` | |
| #python | `59.61% <83.33%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/tasks/thumbnails.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvdGh1bWJuYWlscy5weQ==) | `43.33% <0.00%> (ø)` | |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `73.89% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.34% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `79.52% <100.00%> (ø)` | |
| [superset/utils/screenshots.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2NyZWVuc2hvdHMucHk=) | `36.36% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.14%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `81.77% <0.00%> (-0.41%)` | :arrow_down: |
| ... and [147 more](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=footer). Last update [db88cec...329a194](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#issuecomment-671471408
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=h1) Report
> Merging [#10562](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/db88cec431bca04608c6580192714da03bed1e1b&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10562 +/- ##
==========================================
- Coverage 60.10% 60.08% -0.02%
==========================================
Files 775 775
Lines 36528 36528
Branches 3459 3459
==========================================
- Hits 21955 21949 -6
- Misses 14382 14388 +6
Partials 191 191
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `60.48% <ø> (ø)` | |
| #python | `59.85% <83.33%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/tasks/thumbnails.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvdGh1bWJuYWlscy5weQ==) | `43.33% <0.00%> (ø)` | |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `73.89% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.34% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `79.52% <100.00%> (ø)` | |
| [superset/utils/screenshots.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2NyZWVuc2hvdHMucHk=) | `36.36% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `77.92% <0.00%> (-0.44%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=footer). Last update [db88cec...d453071](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#discussion_r468025755
##########
File path: superset/config.py
##########
@@ -797,6 +797,8 @@ class CeleryConfig: # pylint: disable=too-few-public-methods
# Any config options to be passed as-is to the webdriver
WEBDRIVER_CONFIGURATION: Dict[Any, Any] = {}
+# The webdriver to use supports "chrome" and "firefox"
+WEBDRIVER_TYPE = "firefox"
Review comment:
let's use EMAIL_REPORTS_WEBDRIVER or just converge those 2
easy solution would be:
```
EMAIL_REPORTS_WEBDRIVER = EMAIL_REPORTS_WEBDRIVER
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#discussion_r468655360
##########
File path: superset/config.py
##########
@@ -790,7 +790,7 @@ class CeleryConfig: # pylint: disable=too-few-public-methods
# chrome:
# Requires: headless chrome
# Limitations: unable to generate screenshots of elements
-EMAIL_REPORTS_WEBDRIVER = "firefox"
+WEBDRIVER_TYPE = "firefox"
Review comment:
I believe there are unresolved rendering errors on Firefox. Might not be applicable for thumbs, but worth mentioning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#issuecomment-671471408
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=h1) Report
> Merging [#10562](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/db88cec431bca04608c6580192714da03bed1e1b&el=desc) will **increase** coverage by `4.06%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10562 +/- ##
==========================================
+ Coverage 60.10% 64.17% +4.06%
==========================================
Files 775 775
Lines 36528 36529 +1
Branches 3459 3459
==========================================
+ Hits 21955 23442 +1487
+ Misses 14382 12975 -1407
+ Partials 191 112 -79
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.64% <ø> (?)` | |
| #javascript | `60.48% <ø> (ø)` | |
| #python | `59.61% <83.33%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/tasks/thumbnails.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvdGh1bWJuYWlscy5weQ==) | `43.33% <0.00%> (ø)` | |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `73.89% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.34% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `79.52% <100.00%> (ø)` | |
| [superset/utils/screenshots.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2NyZWVuc2hvdHMucHk=) | `36.36% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.14%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `81.77% <0.00%> (-0.41%)` | :arrow_down: |
| ... and [149 more](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=footer). Last update [db88cec...329a194](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#discussion_r468040415
##########
File path: superset/config.py
##########
@@ -797,6 +797,8 @@ class CeleryConfig: # pylint: disable=too-few-public-methods
# Any config options to be passed as-is to the webdriver
WEBDRIVER_CONFIGURATION: Dict[Any, Any] = {}
+# The webdriver to use supports "chrome" and "firefox"
+WEBDRIVER_TYPE = "firefox"
Review comment:
Maybe took it too far, but I actually removed it now. Tell me know if it's ok by you @bkyryliuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#discussion_r468040415
##########
File path: superset/config.py
##########
@@ -797,6 +797,8 @@ class CeleryConfig: # pylint: disable=too-few-public-methods
# Any config options to be passed as-is to the webdriver
WEBDRIVER_CONFIGURATION: Dict[Any, Any] = {}
+# The webdriver to use supports "chrome" and "firefox"
+WEBDRIVER_TYPE = "firefox"
Review comment:
Maybe took it too far, but I actually removed it now. Tell me if it's ok by you @bkyryliuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#discussion_r468025755
##########
File path: superset/config.py
##########
@@ -797,6 +797,8 @@ class CeleryConfig: # pylint: disable=too-few-public-methods
# Any config options to be passed as-is to the webdriver
WEBDRIVER_CONFIGURATION: Dict[Any, Any] = {}
+# The webdriver to use supports "chrome" and "firefox"
+WEBDRIVER_TYPE = "firefox"
Review comment:
let's use EMAIL_REPORTS_WEBDRIVER or just converge those 2
easy solution would be:
```
WEBDRIVER_TYPE = EMAIL_REPORTS_WEBDRIVER
```
or
```
EMAIL_REPORTS_WEBDRIVER = WEBDRIVER_TYPE
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#issuecomment-671471408
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=h1) Report
> Merging [#10562](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea0db0d1951039757a69d321ea920e0b6fdada67&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10562 +/- ##
==========================================
- Coverage 59.56% 59.30% -0.27%
==========================================
Files 767 767
Lines 36268 36282 +14
Branches 3426 3430 +4
==========================================
- Hits 21603 21516 -87
- Misses 14472 14573 +101
Partials 193 193
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.88% <ø> (-0.02%)` | :arrow_down: |
| #python | `58.96% <71.42%> (-0.42%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/tasks/thumbnails.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvdGh1bWJuYWlscy5weQ==) | `43.33% <0.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `74.16% <50.00%> (ø)` | |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `73.89% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.23% <100.00%> (ø)` | |
| [superset/utils/screenshots.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2NyZWVuc2hvdHMucHk=) | `29.41% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.32% <0.00%> (-1.96%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [13 more](https://codecov.io/gh/apache/incubator-superset/pull/10562/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=footer). Last update [ea0db0d...b3ba2ab](https://codecov.io/gh/apache/incubator-superset/pull/10562?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#discussion_r467834986
##########
File path: superset/charts/api.py
##########
@@ -86,57 +86,58 @@ class ChartRestApi(BaseSupersetModelRestApi):
}
class_permission_name = "SliceModelView"
show_columns = [
- "slice_name",
+ "cache_timeout",
+ "dashboards.dashboard_title",
+ "dashboards.id",
"description",
- "owners.id",
- "owners.username",
"owners.first_name",
+ "owners.id",
"owners.last_name",
- "dashboards.id",
- "dashboards.dashboard_title",
- "viz_type",
+ "owners.username",
"params",
- "cache_timeout",
+ "slice_name",
+ "viz_type",
]
show_select_columns = show_columns + ["table.id"]
list_columns = [
- "id",
- "slice_name",
- "url",
- "description",
- "changed_by_name",
- "changed_by_url",
+ "cache_timeout",
"changed_by.first_name",
"changed_by.last_name",
- "changed_on_utc",
+ "changed_by_name",
+ "changed_by_url",
"changed_on_delta_humanized",
+ "changed_on_utc",
"datasource_id",
- "datasource_type",
"datasource_name_text",
+ "datasource_type",
"datasource_url",
+ "description",
+ "id",
+ "params",
+ "slice_name",
"table.default_endpoint",
"table.table_name",
+ "thumbnail_url",
Review comment:
sorted and added a new field `thumbnail_url`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #10562: fix(thumbnails): missing field, logging and new config var
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org