You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/10 12:46:21 UTC
[GitHub] [flink] pnowojski opened a new pull request #10511:
[FLINK-15076][task] Fix SourceStreamTask cancellation (backport to 1.9)
pnowojski opened a new pull request #10511: [FLINK-15076][task] Fix SourceStreamTask cancellation (backport to 1.9)
URL: https://github.com/apache/flink/pull/10511
Source thread should be interrupted more or less the same way how task thread is
being interrupted. This is important for example as in the scenario presented in the
SourceStreamTaskTest#testCancellationWithSourceBlockedOnLock(). SourceFunction is
blocked while holding checkpointLock, which might prevent task thread from
cancelling properly if the SourceFunction is not interrupted.
## Verifying this change
This PR is adding a couple of tests and modifies some of the existing ones.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services