You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "yuzelin (via GitHub)" <gi...@apache.org> on 2023/03/24 11:24:54 UTC

[GitHub] [incubator-paimon] yuzelin commented on a diff in pull request #711: [core] Public API and add partitionKeys,primaryKeys,options to table

yuzelin commented on code in PR #711:
URL: https://github.com/apache/incubator-paimon/pull/711#discussion_r1147449183


##########
paimon-core/src/main/java/org/apache/paimon/table/Table.java:
##########
@@ -41,6 +43,18 @@ public interface Table extends Serializable {
     /** Returns the row type of this table. */
     RowType rowType();
 
+    /** Partition keys of this table. */
+    List<String> partitionKeys();
+
+    /** Primary keys of this table. */
+    List<String> primaryKeys();
+
+    /** Options of this table. */
+    Map<String, String> options();
+
+    /** Optional comment of this table. */
+    Optional<String> comment();
+

Review Comment:
   Is it necessary to public `fileIO()` ? I think it's useful for creating `SnapshotManager` and `SchemaManager`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org