You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/29 14:24:59 UTC
[GitHub] [apisix] membphis commented on a change in pull request #2566: chore: move try_read_attr function into table.lua (#2257)
membphis commented on a change in pull request #2566:
URL: https://github.com/apache/apisix/pull/2566#discussion_r514298437
##########
File path: apisix/plugins/hmac-auth.lua
##########
@@ -29,6 +28,7 @@ local core = require("apisix.core")
local hmac = require("resty.hmac")
local consumer = require("apisix.consumer")
local ngx_decode_base64 = ngx.decode_base64
+local try_read_attr = core.table.try_read_attr
Review comment:
we do not need to cache it, call `core.table.try_read_attr` is simpler.
##########
File path: apisix/plugins/hmac-auth.lua
##########
@@ -29,6 +28,7 @@ local core = require("apisix.core")
local hmac = require("resty.hmac")
local consumer = require("apisix.consumer")
local ngx_decode_base64 = ngx.decode_base64
+local try_read_attr = core.table.try_read_attr
Review comment:
please fix the similar points
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org