You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/17 08:17:23 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #25758: Used many-to-many relation for finding attached dataset events.

uranusjr commented on code in PR #25758:
URL: https://github.com/apache/airflow/pull/25758#discussion_r947593019


##########
airflow/api_connexion/endpoints/dag_run_endpoint.py:
##########
@@ -116,43 +115,12 @@ def get_upstream_dataset_events(
             "DAGRun not found",
             detail=f"DAGRun with DAG ID: '{dag_id}' and DagRun ID: '{dag_run_id}' not found",
         )
-    events = _get_upstream_dataset_events(dag_run=dag_run, session=session)
+    events = dag_run.dataset_events

Review Comment:
   This seems to be a different value. The previous function retrieves events that triggered `dag_run`, but `dag_run.dataset_events` is the events emitted by the run (if I understand the logic correctly)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org