You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Erik de Bruin <er...@ixsoftware.nl> on 2013/01/11 19:24:43 UTC
[FalconJx] refactoring question
Mike,
I would like to move all methods that do not specifically add 'goog'
code to the JS output 'down' into the JSEmitter. Will that mess with
your work?
EdB
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [FalconJx] refactoring question
Posted by Erik de Bruin <er...@ixsoftware.nl>.
I understand.
I'll take another look at the current setup with the 'module/AMD'
approach in mind, just so we don't code ourselves in a corner by
focussing only on 'goog'.
EdB
On Fri, Jan 11, 2013 at 8:02 PM, Michael Schmalle <mi...@teotigraphix.com> wrote:
>
> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>
>> And I'm reverting out of the refactor again... turns out that the
>> whole structure is geared towards a specific JS approach (prototype
>> based 'class' definition), so a different JS approach (e.g. one using
>> the module pattern) would have to override every method anyway...
>> maybe we should reconsider having the JSEmitter around at all?
>
>
> I created a subclass for logical sake, and note it is represented in an
> interface to separate languages.
>
> I also did this because I thought there might be things that needed
> different handling in JS with primitives, errors blah, blah that could be
> shared. I don't think taking it out is a good idea right now.
>
> What it's doing right now is binding things together which in the beginning
> of a design that is not "technically" pre- thought out completely is a good
> thing.
>
> We can remove it it easily down the road, it's not in the way right now.
>
>
> Mike
>
>> EdB
>>
>>
>>
>> On Fri, Jan 11, 2013 at 7:46 PM, Michael Schmalle
>> <ap...@teotigraphix.com> wrote:
>>>
>>> Yeah, thats right I remember you doing this.
>>>
>>> Ok, that is where I will start writing the things I see that I want to go
>>> back to or work on again.
>>>
>>>
>>>
>>> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>>>
>>>> Like this:
>>>>
>>>> https://cwiki.apache.org/confluence/display/FLEX/ToDo
>>>>
>>>> It's not complete, but it's a place to call 'home' ;-)
>>>>
>>>> Also, I've updated the Full Table to reflect the status of the tests.
>>>>
>>>> Have a look around to see what's keeping my mind busy wrt. the 'goog'
>>>> implementation.
>>>
>>>
>>>
>>> Do you mean your task TODO markers in the code? I have read them and
>>> yesterday I knocked off a couple of yours and mine.
>>>
>>> Mike
>>>
>>>
>>>
>>>> EdB
>>>>
>>>>
>>>>
>>>> On Fri, Jan 11, 2013 at 7:34 PM, Michael Schmalle
>>>> <ap...@teotigraphix.com> wrote:
>>>>>
>>>>>
>>>>> Nope, I haven't done anything since yesterday. I make it a rule that
>>>>> when
>>>>> I
>>>>> finish for the day its with a final commit, or I just revert what I was
>>>>> working on and figure it out when I get back into the code, I never
>>>>> leave
>>>>> anything dangling.
>>>>>
>>>>> Anyway, that sounds fine, if it's abstract js generation, that is where
>>>>> it
>>>>> belongs. :)
>>>>>
>>>>> PS We need to get a TODO page on the WIKI or start create a JIRA task
>>>>> list
>>>>> or something so we can be more pragmatic about what needs to be
>>>>> finished
>>>>> and
>>>>> refactored. I can work 10 times as fast.
>>>>>
>>>>> I know you have been doing the table, but I just need to raw "list" to
>>>>> look
>>>>> at sometimes if you know what I mean, then I can add to it as well.
>>>>>
>>>>> Mike
>>>>>
>>>>>
>>>>>
>>>>> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>>>>>
>>>>>> Mike,
>>>>>>
>>>>>> I would like to move all methods that do not specifically add 'goog'
>>>>>> code to the JS output 'down' into the JSEmitter. Will that mess with
>>>>>> your work?
>>>>>>
>>>>>> EdB
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Ix Multimedia Software
>>>>>>
>>>>>> Jan Luykenstraat 27
>>>>>> 3521 VB Utrecht
>>>>>>
>>>>>> T. 06-51952295
>>>>>> I. www.ixsoftware.nl
>>>>>>
>>>>>
>>>>> --
>>>>> Michael Schmalle - Teoti Graphix, LLC
>>>>> http://www.teotigraphix.com
>>>>> http://blog.teotigraphix.com
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Ix Multimedia Software
>>>>
>>>> Jan Luykenstraat 27
>>>> 3521 VB Utrecht
>>>>
>>>> T. 06-51952295
>>>> I. www.ixsoftware.nl
>>>>
>>>
>>> --
>>> Michael Schmalle - Teoti Graphix, LLC
>>> http://www.teotigraphix.com
>>> http://blog.teotigraphix.com
>>>
>>
>>
>>
>> --
>> Ix Multimedia Software
>>
>> Jan Luykenstraat 27
>> 3521 VB Utrecht
>>
>> T. 06-51952295
>> I. www.ixsoftware.nl
>>
>
>
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [FalconJx] refactoring question
Posted by Michael Schmalle <mi...@teotigraphix.com>.
Quoting Erik de Bruin <er...@ixsoftware.nl>:
> And I'm reverting out of the refactor again... turns out that the
> whole structure is geared towards a specific JS approach (prototype
> based 'class' definition), so a different JS approach (e.g. one using
> the module pattern) would have to override every method anyway...
> maybe we should reconsider having the JSEmitter around at all?
I created a subclass for logical sake, and note it is represented in
an interface to separate languages.
I also did this because I thought there might be things that needed
different handling in JS with primitives, errors blah, blah that could
be shared. I don't think taking it out is a good idea right now.
What it's doing right now is binding things together which in the
beginning of a design that is not "technically" pre- thought out
completely is a good thing.
We can remove it it easily down the road, it's not in the way right now.
Mike
> EdB
>
>
>
> On Fri, Jan 11, 2013 at 7:46 PM, Michael Schmalle
> <ap...@teotigraphix.com> wrote:
>> Yeah, thats right I remember you doing this.
>>
>> Ok, that is where I will start writing the things I see that I want to go
>> back to or work on again.
>>
>>
>>
>> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>>
>>> Like this:
>>>
>>> https://cwiki.apache.org/confluence/display/FLEX/ToDo
>>>
>>> It's not complete, but it's a place to call 'home' ;-)
>>>
>>> Also, I've updated the Full Table to reflect the status of the tests.
>>>
>>> Have a look around to see what's keeping my mind busy wrt. the 'goog'
>>> implementation.
>>
>>
>> Do you mean your task TODO markers in the code? I have read them and
>> yesterday I knocked off a couple of yours and mine.
>>
>> Mike
>>
>>
>>
>>> EdB
>>>
>>>
>>>
>>> On Fri, Jan 11, 2013 at 7:34 PM, Michael Schmalle
>>> <ap...@teotigraphix.com> wrote:
>>>>
>>>> Nope, I haven't done anything since yesterday. I make it a rule that when
>>>> I
>>>> finish for the day its with a final commit, or I just revert what I was
>>>> working on and figure it out when I get back into the code, I never leave
>>>> anything dangling.
>>>>
>>>> Anyway, that sounds fine, if it's abstract js generation, that is where
>>>> it
>>>> belongs. :)
>>>>
>>>> PS We need to get a TODO page on the WIKI or start create a JIRA task
>>>> list
>>>> or something so we can be more pragmatic about what needs to be finished
>>>> and
>>>> refactored. I can work 10 times as fast.
>>>>
>>>> I know you have been doing the table, but I just need to raw "list" to
>>>> look
>>>> at sometimes if you know what I mean, then I can add to it as well.
>>>>
>>>> Mike
>>>>
>>>>
>>>>
>>>> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>>>>
>>>>> Mike,
>>>>>
>>>>> I would like to move all methods that do not specifically add 'goog'
>>>>> code to the JS output 'down' into the JSEmitter. Will that mess with
>>>>> your work?
>>>>>
>>>>> EdB
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Ix Multimedia Software
>>>>>
>>>>> Jan Luykenstraat 27
>>>>> 3521 VB Utrecht
>>>>>
>>>>> T. 06-51952295
>>>>> I. www.ixsoftware.nl
>>>>>
>>>>
>>>> --
>>>> Michael Schmalle - Teoti Graphix, LLC
>>>> http://www.teotigraphix.com
>>>> http://blog.teotigraphix.com
>>>>
>>>
>>>
>>>
>>> --
>>> Ix Multimedia Software
>>>
>>> Jan Luykenstraat 27
>>> 3521 VB Utrecht
>>>
>>> T. 06-51952295
>>> I. www.ixsoftware.nl
>>>
>>
>> --
>> Michael Schmalle - Teoti Graphix, LLC
>> http://www.teotigraphix.com
>> http://blog.teotigraphix.com
>>
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
>
Re: [FalconJx] refactoring question
Posted by Erik de Bruin <er...@ixsoftware.nl>.
And I'm reverting out of the refactor again... turns out that the
whole structure is geared towards a specific JS approach (prototype
based 'class' definition), so a different JS approach (e.g. one using
the module pattern) would have to override every method anyway...
maybe we should reconsider having the JSEmitter around at all?
EdB
On Fri, Jan 11, 2013 at 7:46 PM, Michael Schmalle
<ap...@teotigraphix.com> wrote:
> Yeah, thats right I remember you doing this.
>
> Ok, that is where I will start writing the things I see that I want to go
> back to or work on again.
>
>
>
> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>
>> Like this:
>>
>> https://cwiki.apache.org/confluence/display/FLEX/ToDo
>>
>> It's not complete, but it's a place to call 'home' ;-)
>>
>> Also, I've updated the Full Table to reflect the status of the tests.
>>
>> Have a look around to see what's keeping my mind busy wrt. the 'goog'
>> implementation.
>
>
> Do you mean your task TODO markers in the code? I have read them and
> yesterday I knocked off a couple of yours and mine.
>
> Mike
>
>
>
>> EdB
>>
>>
>>
>> On Fri, Jan 11, 2013 at 7:34 PM, Michael Schmalle
>> <ap...@teotigraphix.com> wrote:
>>>
>>> Nope, I haven't done anything since yesterday. I make it a rule that when
>>> I
>>> finish for the day its with a final commit, or I just revert what I was
>>> working on and figure it out when I get back into the code, I never leave
>>> anything dangling.
>>>
>>> Anyway, that sounds fine, if it's abstract js generation, that is where
>>> it
>>> belongs. :)
>>>
>>> PS We need to get a TODO page on the WIKI or start create a JIRA task
>>> list
>>> or something so we can be more pragmatic about what needs to be finished
>>> and
>>> refactored. I can work 10 times as fast.
>>>
>>> I know you have been doing the table, but I just need to raw "list" to
>>> look
>>> at sometimes if you know what I mean, then I can add to it as well.
>>>
>>> Mike
>>>
>>>
>>>
>>> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>>>
>>>> Mike,
>>>>
>>>> I would like to move all methods that do not specifically add 'goog'
>>>> code to the JS output 'down' into the JSEmitter. Will that mess with
>>>> your work?
>>>>
>>>> EdB
>>>>
>>>>
>>>>
>>>> --
>>>> Ix Multimedia Software
>>>>
>>>> Jan Luykenstraat 27
>>>> 3521 VB Utrecht
>>>>
>>>> T. 06-51952295
>>>> I. www.ixsoftware.nl
>>>>
>>>
>>> --
>>> Michael Schmalle - Teoti Graphix, LLC
>>> http://www.teotigraphix.com
>>> http://blog.teotigraphix.com
>>>
>>
>>
>>
>> --
>> Ix Multimedia Software
>>
>> Jan Luykenstraat 27
>> 3521 VB Utrecht
>>
>> T. 06-51952295
>> I. www.ixsoftware.nl
>>
>
> --
> Michael Schmalle - Teoti Graphix, LLC
> http://www.teotigraphix.com
> http://blog.teotigraphix.com
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [FalconJx] refactoring question
Posted by Michael Schmalle <ap...@teotigraphix.com>.
Yeah, thats right I remember you doing this.
Ok, that is where I will start writing the things I see that I want to
go back to or work on again.
Quoting Erik de Bruin <er...@ixsoftware.nl>:
> Like this:
>
> https://cwiki.apache.org/confluence/display/FLEX/ToDo
>
> It's not complete, but it's a place to call 'home' ;-)
>
> Also, I've updated the Full Table to reflect the status of the tests.
>
> Have a look around to see what's keeping my mind busy wrt. the 'goog'
> implementation.
Do you mean your task TODO markers in the code? I have read them and
yesterday I knocked off a couple of yours and mine.
Mike
> EdB
>
>
>
> On Fri, Jan 11, 2013 at 7:34 PM, Michael Schmalle
> <ap...@teotigraphix.com> wrote:
>> Nope, I haven't done anything since yesterday. I make it a rule that when I
>> finish for the day its with a final commit, or I just revert what I was
>> working on and figure it out when I get back into the code, I never leave
>> anything dangling.
>>
>> Anyway, that sounds fine, if it's abstract js generation, that is where it
>> belongs. :)
>>
>> PS We need to get a TODO page on the WIKI or start create a JIRA task list
>> or something so we can be more pragmatic about what needs to be finished and
>> refactored. I can work 10 times as fast.
>>
>> I know you have been doing the table, but I just need to raw "list" to look
>> at sometimes if you know what I mean, then I can add to it as well.
>>
>> Mike
>>
>>
>>
>> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>>
>>> Mike,
>>>
>>> I would like to move all methods that do not specifically add 'goog'
>>> code to the JS output 'down' into the JSEmitter. Will that mess with
>>> your work?
>>>
>>> EdB
>>>
>>>
>>>
>>> --
>>> Ix Multimedia Software
>>>
>>> Jan Luykenstraat 27
>>> 3521 VB Utrecht
>>>
>>> T. 06-51952295
>>> I. www.ixsoftware.nl
>>>
>>
>> --
>> Michael Schmalle - Teoti Graphix, LLC
>> http://www.teotigraphix.com
>> http://blog.teotigraphix.com
>>
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
>
--
Michael Schmalle - Teoti Graphix, LLC
http://www.teotigraphix.com
http://blog.teotigraphix.com
Re: [FalconJx] refactoring question
Posted by Erik de Bruin <er...@ixsoftware.nl>.
Like this:
https://cwiki.apache.org/confluence/display/FLEX/ToDo
It's not complete, but it's a place to call 'home' ;-)
Also, I've updated the Full Table to reflect the status of the tests.
Have a look around to see what's keeping my mind busy wrt. the 'goog'
implementation.
EdB
On Fri, Jan 11, 2013 at 7:34 PM, Michael Schmalle
<ap...@teotigraphix.com> wrote:
> Nope, I haven't done anything since yesterday. I make it a rule that when I
> finish for the day its with a final commit, or I just revert what I was
> working on and figure it out when I get back into the code, I never leave
> anything dangling.
>
> Anyway, that sounds fine, if it's abstract js generation, that is where it
> belongs. :)
>
> PS We need to get a TODO page on the WIKI or start create a JIRA task list
> or something so we can be more pragmatic about what needs to be finished and
> refactored. I can work 10 times as fast.
>
> I know you have been doing the table, but I just need to raw "list" to look
> at sometimes if you know what I mean, then I can add to it as well.
>
> Mike
>
>
>
> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>
>> Mike,
>>
>> I would like to move all methods that do not specifically add 'goog'
>> code to the JS output 'down' into the JSEmitter. Will that mess with
>> your work?
>>
>> EdB
>>
>>
>>
>> --
>> Ix Multimedia Software
>>
>> Jan Luykenstraat 27
>> 3521 VB Utrecht
>>
>> T. 06-51952295
>> I. www.ixsoftware.nl
>>
>
> --
> Michael Schmalle - Teoti Graphix, LLC
> http://www.teotigraphix.com
> http://blog.teotigraphix.com
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [FalconJx] refactoring question
Posted by Michael Schmalle <ap...@teotigraphix.com>.
Nope, I haven't done anything since yesterday. I make it a rule that
when I finish for the day its with a final commit, or I just revert
what I was working on and figure it out when I get back into the code,
I never leave anything dangling.
Anyway, that sounds fine, if it's abstract js generation, that is
where it belongs. :)
PS We need to get a TODO page on the WIKI or start create a JIRA task
list or something so we can be more pragmatic about what needs to be
finished and refactored. I can work 10 times as fast.
I know you have been doing the table, but I just need to raw "list" to
look at sometimes if you know what I mean, then I can add to it as well.
Mike
Quoting Erik de Bruin <er...@ixsoftware.nl>:
> Mike,
>
> I would like to move all methods that do not specifically add 'goog'
> code to the JS output 'down' into the JSEmitter. Will that mess with
> your work?
>
> EdB
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
>
--
Michael Schmalle - Teoti Graphix, LLC
http://www.teotigraphix.com
http://blog.teotigraphix.com