[GitHub] [kafka] dongjinleekr edited a comment on pull request #8150: KAFKA-9587: Producer configs are omitted in the documentation

[GitBox <gi...@apache.org>]

dongjinleekr edited a comment on pull request #8150:
URL: https://github.com/apache/kafka/pull/8150#issuecomment-649403477


   Rebased onto the latest trunk and I reviewed the problem more carefully and here is the summary:
   
   1. As @kkonstantine stated, [the default value of `retries` config is `Integer.MAX_VALUE`](https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java#L289); however, the documentation still states that **'though since we have specified <code>retries</code> as 0 it won't.'** It seems like `props.put("retries", 0);` was removed mistakenly from example code snippet in commit c3e7c0b (2.1.0).
   
   2. The default value of `linger.ms` config is 0; however, the current documentation states that **we set our linger time to 1 millisecond**. `props.put("linger.ms", 1);` was removed from example code snippet in commit 975b680 (2.2.0), for the example code of that times violates `delivery.timeout.ms` (30000) >= `linger.ms` (1) + `request.timeout.ms` (30000 by default). However, it should not have be removed since removing `delivery.timeout.ms` only was enough - `delivery.timeout.ms` defaults to 120000. In conclusion, it seems like `props.put("linger.ms", 1);` was also removed mistakenly.
   
   cc for the reviewers of commit c3e7c0b and 975b680. @ijuma @guozhangwang @hachikuji
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org