[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #244: [YUNIKORN-530] scheduler-core repo: migrate to github action

[GitBox <gi...@apache.org>]

wilfred-s commented on a change in pull request #244:
URL: https://github.com/apache/incubator-yunikorn-core/pull/244#discussion_r567513857



##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,34 @@
+name: Pre-commit checks
+
+on:
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Set up Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: 1.15
+
+      - name: Checkout source code
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0

Review comment:
       We do not need all logs etc in YUNIKORN-285 we changed the fetch depth to 2 to make it all work and it safes a lot of data being pulled out.
   We should have `fetch-depth: 2`, will fix on commit




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org