[jira] [Commented] (ROCKETMQ-91) Reduce lock granularity for putMessage

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946635#comment-15946635 ] 

ASF GitHub Bot commented on ROCKETMQ-91:
----------------------------------------

Github user vongosling commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/57
  
    LGTM


> Reduce lock granularity for putMessage
> --------------------------------------
>
>                 Key: ROCKETMQ-91
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-91
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>    Affects Versions: 4.1.0-incubating
>            Reporter: dongeforever
>            Assignee: dongeforever
>             Fix For: 4.1.0-incubating
>
>
> CommitLog putMessage has a lock as:
> lockForPutMessage()
> ....
> releasePutMessageLock()
> The logic inside the lock includes two main operations:
> 1 encode the message
> 2 write to the PageCache.
> However, we can take the first operation(encode message) out from the lock to achieve better performance.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)