[jira] [Commented] (BEAM-242) Enable Checkstyle check and Javadoc build for the Flink Runner

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435049#comment-15435049 ] 

ASF GitHub Bot commented on BEAM-242:
-------------------------------------

GitHub user jbonofre opened a pull request:

    https://github.com/apache/incubator-beam/pull/874

    [BEAM-242] Enable checkstyle and fix checkstyle errors in Flink runner

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbonofre/incubator-beam BEAM-242

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/874.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #874
    
----

----


> Enable Checkstyle check and Javadoc build for the Flink Runner 
> ---------------------------------------------------------------
>
>                 Key: BEAM-242
>                 URL: https://issues.apache.org/jira/browse/BEAM-242
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-flink
>            Reporter: Maximilian Michels
>            Assignee: Jean-Baptiste Onofré
>            Priority: Minor
>
> We don't have a Checkstyle check in place for the Flink Runner. I would like to use the SDK's checkstyle rules.
> We could also think about a unified Checkstyle for all Runners.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)