You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/20 15:09:31 UTC
[GitHub] [kafka] bbejeck opened a new pull request #9461: MINOR: Clean-up streams javadoc warnings
bbejeck opened a new pull request #9461:
URL: https://github.com/apache/kafka/pull/9461
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9461: MINOR: Clean-up streams javadoc warnings
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9461:
URL: https://github.com/apache/kafka/pull/9461#issuecomment-713200696
cherry-picked to 2.7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9461: MINOR: Clean-up streams javadoc warnings
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9461:
URL: https://github.com/apache/kafka/pull/9461#issuecomment-712922842
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9461: MINOR: Clean-up streams javadoc warnings
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9461:
URL: https://github.com/apache/kafka/pull/9461#issuecomment-712924272
ping one of @abbccdda, @ableegoldman, @mjsax, @vvcephei for review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a change in pull request #9461: MINOR: Clean-up streams javadoc warnings
Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #9461:
URL: https://github.com/apache/kafka/pull/9461#discussion_r508705351
##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/CogroupedKStream.java
##########
@@ -184,9 +184,9 @@
* <pre>
* KafkaStreams streams = ... // some aggregation on value type double
* String queryableStoreName = "storeName" // the store name should be the name of the store as defined by the Materialized instance
- * ReadOnlyKeyValueStore<K, ValueAndTimestamp<VOut>> localStore = streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<VOut>> timestampedKeyValueStore());
+ * ReadOnlyKeyValueStore>K, ValueAndTimestamp>VOut<< localStore = streams.store(queryableStoreName, QueryableStoreTypes.>K, ValueAndTimestamp>VOut<< timestampedKeyValueStore());
Review comment:
I seem the right fix would be to add the missing `{@code }` annotation in L184?
```
<pre>{@code
```
The closing `}` is already in L190.
##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/CogroupedKStream.java
##########
@@ -236,9 +236,9 @@
* <pre>
* KafkaStreams streams = ... // some aggregation on value type double
* String queryableStoreName = "storeName" // the store name should be the name of the store as defined by the Materialized instance
- * ReadOnlyKeyValueStore<K, ValueAndTimestamp<VOut>> localStore = streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<VOut>> timestampedKeyValueStore());
Review comment:
As above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck merged pull request #9461: MINOR: Clean-up streams javadoc warnings
Posted by GitBox <gi...@apache.org>.
bbejeck merged pull request #9461:
URL: https://github.com/apache/kafka/pull/9461
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on a change in pull request #9461: MINOR: Clean-up streams javadoc warnings
Posted by GitBox <gi...@apache.org>.
bbejeck commented on a change in pull request #9461:
URL: https://github.com/apache/kafka/pull/9461#discussion_r508806985
##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/CogroupedKStream.java
##########
@@ -184,9 +184,9 @@
* <pre>
* KafkaStreams streams = ... // some aggregation on value type double
* String queryableStoreName = "storeName" // the store name should be the name of the store as defined by the Materialized instance
- * ReadOnlyKeyValueStore<K, ValueAndTimestamp<VOut>> localStore = streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<VOut>> timestampedKeyValueStore());
+ * ReadOnlyKeyValueStore>K, ValueAndTimestamp>VOut<< localStore = streams.store(queryableStoreName, QueryableStoreTypes.>K, ValueAndTimestamp>VOut<< timestampedKeyValueStore());
Review comment:
Ah, good catch I'll update this and the next.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9461: MINOR: Clean-up streams javadoc warnings
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9461:
URL: https://github.com/apache/kafka/pull/9461#issuecomment-713197394
java doc changes only, so merging this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9461: MINOR: Clean-up streams javadoc warnings
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9461:
URL: https://github.com/apache/kafka/pull/9461#issuecomment-713200300
merged #9461 into trunk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org