You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/10/27 09:05:40 UTC
[GitHub] [activemq-artemis] gemmellr commented on a diff in pull request #4256: ARTEMIS-4045 Fixing in Handler ACKRunner on Mirror
gemmellr commented on code in PR #4256:
URL: https://github.com/apache/activemq-artemis/pull/4256#discussion_r1006602708
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerTarget.java:
##########
@@ -120,6 +120,11 @@ ACKMessageOperation setDelivery(Delivery delivery) {
@Override
public void run() {
+ if (!connection.isHandler()) {
+ logger.info("Moving execution to proton handler");
Review Comment:
Should this be info? Feels more like its either expected to happen, and so e.g trace or debug, or not expected and so perhaps even warn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org