[GitHub] leventov commented on a change in pull request #6939: Throw caught exception.

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #6939: Throw caught exception.
URL: https://github.com/apache/incubator-druid/pull/6939#discussion_r253420659
 
 

 ##########
 File path: codestyle/checkstyle.xml
 ##########
 @@ -204,6 +204,12 @@
       <property name="message" value="Use org.apache.druid.server.http.HttpMediaType#TEXT_PLAIN_UTF8 instead"/>
     </module>
 
+    <module name="Regexp">
+      <property name="format" value='^((?!throw|=).)* Throwables.propagate\('/>
+      <property name="illegalPattern" value="true"/>
+      <property name="message" value="Throw caught exception"/>
 
 Review comment:
   I would say something like `Throwables.propagate() shouldn't be used in new code. See https://github.com/google/guava/wiki/Why-we-deprecated-Throwables.propagate`. We don't prohibit `Throwables.propagate()` right away via forbidden-apis only because there are so much uses in the codebase and that's a huge undertaking to fix them all.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org