You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/01/27 05:15:39 UTC

Review Request 30307: Failing to register hosts on Centos5

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30307/
-----------------------------------------------------------

Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, and Yusaku Sako.


Bugs: AMBARI-9341
    https://issues.apache.org/jira/browse/AMBARI-9341


Repository: ambari


Description
-------

+Fixed the ambari_commons imports to only include the bare minimum required to function
+Fixed the incompartibilities with Python 2.4


Diffs
-----

  ambari-common/src/main/python/ambari_commons/__init__.py df4d7d68e6efcb9e8aeede1e43f060b76b46b204 
  ambari-server/src/main/python/bootstrap.py 8ac6a370e5b84400ab04fa7614da88d5e6941566 
  ambari-server/src/main/python/setupAgent.py 8f9c48f03f545227e88042c03a3ee19a1651a67e 

Diff: https://reviews.apache.org/r/30307/diff/


Testing
-------

mvn clean test
manual simulation of the agent registration process, due to the absence of a fake yum repository -> scripts run ok


Thanks,

Florian Barca

Re: Review Request 30307: Failing to register hosts on Centos5

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30307/#review69773
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On Jan. 27, 2015, 4:15 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30307/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 4:15 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-9341
>     https://issues.apache.org/jira/browse/AMBARI-9341
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> +Fixed the ambari_commons imports to only include the bare minimum required to function
> +Fixed the incompartibilities with Python 2.4
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/__init__.py df4d7d68e6efcb9e8aeede1e43f060b76b46b204 
>   ambari-server/src/main/python/bootstrap.py 8ac6a370e5b84400ab04fa7614da88d5e6941566 
>   ambari-server/src/main/python/setupAgent.py 8f9c48f03f545227e88042c03a3ee19a1651a67e 
> 
> Diff: https://reviews.apache.org/r/30307/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> manual simulation of the agent registration process, due to the absence of a fake yum repository -> scripts run ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>

Re: Review Request 30307: Failing to register hosts on Centos5

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30307/#review69892
-----------------------------------------------------------

Ship it!


Ship It!

- Jayush Luniya


On Jan. 27, 2015, 8:05 p.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30307/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 8:05 p.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-9341
>     https://issues.apache.org/jira/browse/AMBARI-9341
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> +Fixed the ambari_commons imports to only include the bare minimum required to function
> +Fixed the incompartibilities with Python 2.4
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 7a1dbb781f49e66ea5151778c47f0829e81a9977 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py adeb798268a7f3e7c07ad7858a9a6d8febe62b5e 
>   ambari-agent/src/test/python/ambari_agent/TestRegistration.py 92e4b36266a2bf6c2bd3263ed133dd27bc1fec68 
>   ambari-common/src/main/python/ambari_commons/__init__.py df4d7d68e6efcb9e8aeede1e43f060b76b46b204 
>   ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 402b42172647949107af96d45204c98584f9e9af 
>   ambari-server/src/main/python/bootstrap.py 8ac6a370e5b84400ab04fa7614da88d5e6941566 
>   ambari-server/src/main/python/setupAgent.py 8216c98016a9d7f3317e13ded8fdec367abfe182 
>   ambari-server/src/test/python/TestAmbariServer.py 8f1329565e7093fa8ace89711f46c5f0c81deb62 
> 
> Diff: https://reviews.apache.org/r/30307/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> manual simulation of the agent registration process, due to the absence of a fake yum repository -> scripts run ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>

Re: Review Request 30307: Failing to register hosts on Centos5

Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30307/
-----------------------------------------------------------

(Updated Jan. 27, 2015, 8:05 p.m.)


Review request for Ambari, Artem Baranchuk, Andrew Onischuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, and Yusaku Sako.


Changes
-------

Fixed import statements


Bugs: AMBARI-9341
    https://issues.apache.org/jira/browse/AMBARI-9341


Repository: ambari


Description
-------

+Fixed the ambari_commons imports to only include the bare minimum required to function
+Fixed the incompartibilities with Python 2.4


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/HostInfo.py 7a1dbb781f49e66ea5151778c47f0829e81a9977 
  ambari-agent/src/test/python/ambari_agent/TestHostInfo.py adeb798268a7f3e7c07ad7858a9a6d8febe62b5e 
  ambari-agent/src/test/python/ambari_agent/TestRegistration.py 92e4b36266a2bf6c2bd3263ed133dd27bc1fec68 
  ambari-common/src/main/python/ambari_commons/__init__.py df4d7d68e6efcb9e8aeede1e43f060b76b46b204 
  ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 402b42172647949107af96d45204c98584f9e9af 
  ambari-server/src/main/python/bootstrap.py 8ac6a370e5b84400ab04fa7614da88d5e6941566 
  ambari-server/src/main/python/setupAgent.py 8216c98016a9d7f3317e13ded8fdec367abfe182 
  ambari-server/src/test/python/TestAmbariServer.py 8f1329565e7093fa8ace89711f46c5f0c81deb62 

Diff: https://reviews.apache.org/r/30307/diff/


Testing
-------

mvn clean test
manual simulation of the agent registration process, due to the absence of a fake yum repository -> scripts run ok


Thanks,

Florian Barca

Re: Review Request 30307: Failing to register hosts on Centos5

Posted by Florian Barca <fb...@hortonworks.com>.

> On Jan. 27, 2015, 8:33 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/python/setupAgent.py, line 32
> > <https://reviews.apache.org/r/30307/diff/1/?file=836154#file836154line32>
> >
> >     Change to OSCheck import doesnt seem to be required.

The issue is a bit more cumbersome than it seems. Ironically, the production code is more relaxed due to the existence of the "all" clause in __init__. The test code will have issues though, because of the way the mocks work, which require the imports' syntax to be normalized, one way or the other. So, this file is ok, but expect changes in the test scripts.


- Florian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30307/#review69764
-----------------------------------------------------------


On Jan. 27, 2015, 4:15 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30307/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 4:15 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-9341
>     https://issues.apache.org/jira/browse/AMBARI-9341
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> +Fixed the ambari_commons imports to only include the bare minimum required to function
> +Fixed the incompartibilities with Python 2.4
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/__init__.py df4d7d68e6efcb9e8aeede1e43f060b76b46b204 
>   ambari-server/src/main/python/bootstrap.py 8ac6a370e5b84400ab04fa7614da88d5e6941566 
>   ambari-server/src/main/python/setupAgent.py 8f9c48f03f545227e88042c03a3ee19a1651a67e 
> 
> Diff: https://reviews.apache.org/r/30307/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> manual simulation of the agent registration process, due to the absence of a fake yum repository -> scripts run ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>

Re: Review Request 30307: Failing to register hosts on Centos5

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30307/#review69764
-----------------------------------------------------------



ambari-common/src/main/python/ambari_commons/__init__.py
<https://reviews.apache.org/r/30307/#comment114575>

    You will need to update the imports of Firewall, FirewallChecks across the files. 
    
    Ex: ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py
    ambari-agent/src/main/python/ambari_agent/HostInfo.py
    TestHostInfo.py
    TestRegistration.py
    TestAmbariServer.py



ambari-server/src/main/python/setupAgent.py
<https://reviews.apache.org/r/30307/#comment114576>

    Change to OSCheck import doesnt seem to be required.


- Jayush Luniya


On Jan. 27, 2015, 4:15 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30307/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 4:15 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-9341
>     https://issues.apache.org/jira/browse/AMBARI-9341
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> +Fixed the ambari_commons imports to only include the bare minimum required to function
> +Fixed the incompartibilities with Python 2.4
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/__init__.py df4d7d68e6efcb9e8aeede1e43f060b76b46b204 
>   ambari-server/src/main/python/bootstrap.py 8ac6a370e5b84400ab04fa7614da88d5e6941566 
>   ambari-server/src/main/python/setupAgent.py 8f9c48f03f545227e88042c03a3ee19a1651a67e 
> 
> Diff: https://reviews.apache.org/r/30307/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> manual simulation of the agent registration process, due to the absence of a fake yum repository -> scripts run ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>

Re: Review Request 30307: Failing to register hosts on Centos5

Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30307/
-----------------------------------------------------------

(Updated Jan. 27, 2015, 4:15 a.m.)


Review request for Ambari, Artem Baranchuk, Andrew Onischuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, and Yusaku Sako.


Bugs: AMBARI-9341
    https://issues.apache.org/jira/browse/AMBARI-9341


Repository: ambari


Description
-------

+Fixed the ambari_commons imports to only include the bare minimum required to function
+Fixed the incompartibilities with Python 2.4


Diffs
-----

  ambari-common/src/main/python/ambari_commons/__init__.py df4d7d68e6efcb9e8aeede1e43f060b76b46b204 
  ambari-server/src/main/python/bootstrap.py 8ac6a370e5b84400ab04fa7614da88d5e6941566 
  ambari-server/src/main/python/setupAgent.py 8f9c48f03f545227e88042c03a3ee19a1651a67e 

Diff: https://reviews.apache.org/r/30307/diff/


Testing
-------

mvn clean test
manual simulation of the agent registration process, due to the absence of a fake yum repository -> scripts run ok


Thanks,

Florian Barca