You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2013/09/24 00:59:12 UTC
Class name org.apache.logging.log4j.LoggingException
Hi All:
I would expected a LoggingException to be in the org.apache.logging package
and be used by all org.apache.logging logging solutions, of which there is
only one now: Log4j,
In org.apache.logging.log4j, I would expect us to have a Log4jException.
I propose:
(1) renaming org.apache.logging.log4j.LoggingException to
org.apache.logging.log4j.Log4jException
or moving org.apache.logging.log4j.LoggingException to org.apache.logging.
Since we are not talking about multiple Java logging frameworks, I prefer 1.
Thoughts?
Gary
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Class name org.apache.logging.log4j.LoggingException
Posted by Ralph Goers <ra...@dslextreme.com>.
I don't really like "Log4jException". Log4j is a noun while Logging is a verb - it is not meant to imply an exception that applies to all of org.apache.logging but an exception performing logging within Log4j. As such, its current name and package seem quite appropriate to me.
Ralph
On Sep 23, 2013, at 3:59 PM, Gary Gregory wrote:
> Hi All:
>
> I would expected a LoggingException to be in the org.apache.logging package and be used by all org.apache.logging logging solutions, of which there is only one now: Log4j,
>
> In org.apache.logging.log4j, I would expect us to have a Log4jException.
>
> I propose:
>
> (1) renaming org.apache.logging.log4j.LoggingException to org.apache.logging.log4j.Log4jException
>
> or moving org.apache.logging.log4j.LoggingException to org.apache.logging.
>
> Since we are not talking about multiple Java logging frameworks, I prefer 1.
>
> Thoughts?
>
> Gary
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
Re: Class name org.apache.logging.log4j.LoggingException
Posted by Ralph Goers <ra...@dslextreme.com>.
IO (input/output) is a verb (or at least some kind of action).
That said, regardless of whether the noun vs verb argument makes any sense I still don't think renaming is necessary.
Raph
On Sep 23, 2013, at 4:27 PM, Gary Gregory wrote:
> Hi Ralph,
>
> I don't buy the noun vs. verb argument. What about IOException and SQLException? By that argument we'd have SQLingExcption and IOingException ;) There are plenty of <Product>Exception and <Component>Exception. IllegalStateException is another good one, it denotes state, not that you are doing something. Both verb and noun patterns are valid IMO.
>
> G
>
>
> On Mon, Sep 23, 2013 at 7:17 PM, Ralph Goers <ra...@dslextreme.com> wrote:
> I don't really like "Log4jException". Log4j is a noun while Logging is a verb - it is not meant to imply an exception that applies to all of org.apache.logging but an exception performing logging within Log4j. As such, its current name and package seem quite appropriate to me.
>
> Ralph
>
> On Sep 23, 2013, at 3:59 PM, Gary Gregory wrote:
>
>> Hi All:
>>
>> I would expected a LoggingException to be in the org.apache.logging package and be used by all org.apache.logging logging solutions, of which there is only one now: Log4j,
>>
>> In org.apache.logging.log4j, I would expect us to have a Log4jException.
>>
>> I propose:
>>
>> (1) renaming org.apache.logging.log4j.LoggingException to org.apache.logging.log4j.Log4jException
>>
>> or moving org.apache.logging.log4j.LoggingException to org.apache.logging.
>>
>> Since we are not talking about multiple Java logging frameworks, I prefer 1.
>>
>> Thoughts?
>>
>> Gary
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> JUnit in Action, Second Edition
>> Spring Batch in Action
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
Re: Class name org.apache.logging.log4j.LoggingException
Posted by Gary Gregory <ga...@gmail.com>.
Hi Ralph,
I don't buy the noun vs. verb argument. What about IOException and
SQLException? By that argument we'd have SQLingExcption and IOingException
;) There are plenty of <Product>Exception and <Component>Exception.
IllegalStateException is another good one, it denotes state, not that you
are doing something. Both verb and noun patterns are valid IMO.
G
On Mon, Sep 23, 2013 at 7:17 PM, Ralph Goers <ra...@dslextreme.com>wrote:
> I don't really like "Log4jException". Log4j is a noun while Logging is a
> verb - it is not meant to imply an exception that applies to all of
> org.apache.logging but an exception performing logging within Log4j. As
> such, its current name and package seem quite appropriate to me.
>
> Ralph
>
> On Sep 23, 2013, at 3:59 PM, Gary Gregory wrote:
>
> Hi All:
>
> I would expected a LoggingException to be in the org.apache.logging
> package and be used by all org.apache.logging logging solutions, of which
> there is only one now: Log4j,
>
> In org.apache.logging.log4j, I would expect us to have a Log4jException.
>
> I propose:
>
> (1) renaming org.apache.logging.log4j.LoggingException to
> org.apache.logging.log4j.Log4jException
>
> or moving org.apache.logging.log4j.LoggingException to org.apache.logging.
>
> Since we are not talking about multiple Java logging frameworks, I prefer
> 1.
>
> Thoughts?
>
> Gary
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Class name org.apache.logging.log4j.LoggingException
Posted by Ralph Goers <ra...@dslextreme.com>.
I don't really like "Log4jException". Log4j is a noun while Logging is a verb - it is not meant to imply an exception that applies to all of org.apache.logging but an exception performing logging within Log4j. As such, its current name and package seem quite appropriate to me.
Ralph
On Sep 23, 2013, at 3:59 PM, Gary Gregory wrote:
> Hi All:
>
> I would expected a LoggingException to be in the org.apache.logging package and be used by all org.apache.logging logging solutions, of which there is only one now: Log4j,
>
> In org.apache.logging.log4j, I would expect us to have a Log4jException.
>
> I propose:
>
> (1) renaming org.apache.logging.log4j.LoggingException to org.apache.logging.log4j.Log4jException
>
> or moving org.apache.logging.log4j.LoggingException to org.apache.logging.
>
> Since we are not talking about multiple Java logging frameworks, I prefer 1.
>
> Thoughts?
>
> Gary
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory