[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #4388: Add OLAP_ERR_DATE_QUALITY_ERR error status to display schema change failure

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on a change in pull request #4388:
URL: https://github.com/apache/incubator-doris/pull/4388#discussion_r474424442



##########
File path: be/src/olap/schema_change.cpp
##########
@@ -385,37 +385,37 @@ bool count_field(RowCursor* read_helper, RowCursor* write_helper, const TabletCo
     return true;
 }
 
-bool RowBlockChanger::change_row_block(const RowBlock* ref_block, int32_t data_version,
+OLAPStatus RowBlockChanger::change_row_block(const RowBlock* ref_block, int32_t data_version,
                                        RowBlock* mutable_block, uint64_t* filtered_rows) const {
     if (mutable_block == nullptr) {
         LOG(FATAL) << "mutable block is uninitialized.";
-        return false;
+        return OLAP_ERR_NOT_INITED;

Review comment:
       Could you please add docs to explain what these error codes mean.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org