Re: [Apache Bloodhound] #204: Activity feed currently breaks new ticket page link

[Gary Martin <ga...@wandisco.com>]

Hi,

Spotted this bug in new installs, at least with the recent changes 
activity feeds. Essentially the newticket view (currently available as 
one of the links under the Apps section of the menu) fails to render 
when there are no tickets in the system. The error (as noted in the 
ticket itself) is something like this:

    File
      "/home/bloodhound/bh/bloodhound/bloodhound_dashboard/bhdashboard/widgets/templates/widget_timeline.html",
      line 54, in <Expression u'summary_of(context.resource)'>
        No events reported for <em>${summary_of(context.resource)}</em> in the
      File "/home/bloodhound/bh/bloodhound/trac/trac/resource.py", line 347, in
      get_resource_summary
        return get_resource_description(env, resource, 'summary')
      File "/home/bloodhound/bh/bloodhound/trac/trac/resource.py", line 333, in
      get_resource_description
        return manager.get_resource_description(resource, format, **kwargs)
      File "/home/bloodhound/bh/bloodhound/trac/trac/ticket/api.py", line 555,
      in get_resource_description
        return self.format_summary(*args)
      File "/home/bloodhound/bh/bloodhound/trac/trac/ticket/api.py", line 561,
      in format_summary
        summary = type + ': ' + summary

The diff I suggest below is a possible workaround but it may be worth 
considering alternatives to make the underlying code more robust instead.

Cheers,
     Gary

On 09/19/2012 05:20 PM, Apache Bloodhound wrote:
> #204: Activity feed currently breaks new ticket page link
> ------------------------+-----------------------
>    Reporter:  gjm        |      Owner:  nobody
>        Type:  defect     |     Status:  new
>    Priority:  critical   |  Milestone:  Release 2
>   Component:  dashboard  |    Version:
> Resolution:             |   Keywords:
> ------------------------+-----------------------
>
> Comment (by gjm):
>
>   I expect something like this might help as a quick hack but is there a
>   better answer?
>
>   {{{
>   #!diff
>   Index:
>   bloodhound_dashboard/bhdashboard/widgets/templates/widget_timeline.html
>   ===================================================================
>   ---
>   bloodhound_dashboard/bhdashboard/widgets/templates/widget_timeline.html
>   (revision 1387596)
>   +++
>   bloodhound_dashboard/bhdashboard/widgets/templates/widget_timeline.html
>   (working copy)
>   @@ -50,6 +50,7 @@
>        </tbody>
>      </table>
>      <py:otherwise>
>   +    <py:if test="context.resource.id">
>        <py:def function="timeline_empty()">
>          No events reported for <em>${summary_of(context.resource)}</em> in
>   the
>          last <em>$daysback</em> days since
>   @@ -59,5 +60,6 @@
>        </py:def>
>        <xi:include href="widget_alert.html"
>            py:with="msglabel = 'Warning'; msgbody = timeline_empty()" />
>   +    </py:if>
>      </py:otherwise>
>    </div>
>   }}}
>