You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by hellodengfei <gi...@git.apache.org> on 2018/01/18 02:14:48 UTC
[GitHub] spark pull request #20304: [SPARK-23139]Read eventLog file with mixed encodi...
GitHub user hellodengfei opened a pull request:
https://github.com/apache/spark/pull/20304
[SPARK-23139]Read eventLog file with mixed encodings
## What changes were proposed in this pull request?
EventLog may contain mixed encodings such as custom exception message, but caused to replay failure
## How was this patch tested?
manual test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hellodengfei/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20304
----
commit 4e67ab96027f5de942c25eb14669d5aedae80204
Author: daniedeng(邓飞) <da...@...>
Date: 2018-01-17T12:32:10Z
Read eventLog file with mixed encodings
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20304: [SPARK-23139]Read eventLog file with mixed encodings
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20304
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20304: [SPARK-23139]Read eventLog file with mixed encodings
Posted by hellodengfei <gi...@git.apache.org>.
Github user hellodengfei commented on the issue:
https://github.com/apache/spark/pull/20304
Sorry, it's too late for UT.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20304: [SPARK-23139]Read eventLog file with mixed encodi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20304
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20304: [SPARK-23139]Read eventLog file with mixed encodings
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20304
ping @hellodengfei
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20304: [SPARK-23139]Read eventLog file with mixed encodings
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20304
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20304: [SPARK-23139]Read eventLog file with mixed encodings
Posted by jiangxb1987 <gi...@git.apache.org>.
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/20304
Can you also add test case for this?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20304: [SPARK-23139]Read eventLog file with mixed encodings
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20304
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20304: [SPARK-23139]Read eventLog file with mixed encodings
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20304
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20304: [SPARK-23139]Read eventLog file with mixed encodings
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20304
Do you plan to address the feedback provided in jira about forcing UTF8 on the read and write paths?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org