[jira] [Commented] (MSHARED-1286) Display optional attribute for dependency in tree

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHARED-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745300#comment-17745300 ] 

ASF GitHub Bot commented on MSHARED-1286:
-----------------------------------------

slawekjaranowski commented on code in PR #37:
URL: https://github.com/apache/maven-dependency-tree/pull/37#discussion_r1270057090


##########
src/test/java/org/apache/maven/shared/dependency/graph/internal/DefaultDependencyNodeTest.java:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.shared.dependency.graph.internal;
+
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.DefaultArtifact;
+import org.junit.Test;
+
+import static java.util.Collections.emptyList;
+import static org.junit.Assert.*;

Review Comment:
   Please don't use asterisk for imports



##########
pom.xml:
##########
@@ -96,6 +96,13 @@
       <version>1</version>
       <optional>true</optional>
     </dependency>
+
+    <dependency>
+      <groupId>junit</groupId>
+      <artifactId>junit</artifactId>
+      <version>4.13.2</version>
+      <scope>test</scope>
+    </dependency>

Review Comment:
   Please use JUnit 5





> Display optional attribute for dependency in tree
> -------------------------------------------------
>
>                 Key: MSHARED-1286
>                 URL: https://issues.apache.org/jira/browse/MSHARED-1286
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-dependency-tree
>            Reporter: Slawomir Jaranowski
>            Priority: Major
>             Fix For: maven-dependency-tree-next-release
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)