[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11183: [BUG-11181] [Document] text check

[GitBox <gi...@apache.org>]

EricGao888 commented on code in PR #11183:
URL: https://github.com/apache/dolphinscheduler/pull/11183#discussion_r931926926


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java:
##########
@@ -607,7 +607,7 @@ private Map<String, Object> insertCommand(User loginUser, Integer instanceId, lo
     }
 
     /**
-     * check if sub processes are offline before starting process definition
+     * check whether sub processes are offline before starting process definition

Review Comment:
   `sub processes` or `subprocesses`? I think either one is ok but just keep it consistent.



##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java:
##########
@@ -940,7 +940,7 @@ private List<DependentProcessDefinition> checkDependentProcessDefinitionValid(
 
     /**
      * @param schedule
-     * @return check error return 0 otherwish 1
+     * @return check error return 0 otherwise 1

Review Comment:
   ```suggestion
        * @return check error return 0, otherwise 1
   ```



##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java:
##########
@@ -724,7 +724,7 @@ private int createCommand(CommandType commandType, long processDefineCode, TaskD
                 return createComplementCommandList(schedule, runMode, command, expectedParallelismNumber,
                     complementDependentMode);
             } catch (CronParseException cronParseException) {
-                // this just make compile happy, since we already validate the cron before
+                // this just make compile happen, since we already validate the cron before

Review Comment:
   Not sure what this comment means here. It makes developers confused. If we do not need this, maybe we could just delete it.



##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java:
##########
@@ -294,7 +294,7 @@ public Map<String, Object> checkProcessDefinitionValid(long projectCode, Process
     }
 
     /**
-     * check if the current process has subprocesses and all subprocesses are valid
+     * check whether the current process has subprocesses and valid all subprocesses

Review Comment:
   ```suggestion
        * check whether the current process has subprocesses and validate all subprocesses
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org