You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/14 08:48:44 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1263: fix: sensor: add sensor type of cap
xiaoxiang781216 opened a new pull request, #1263:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1263
## Summary
Increase the type of cap sensor, including raw data and detection status.
## Impact
New type
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1263: fix: sensor: add sensor type of cap
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #1263:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1263: fix: sensor: add sensor type of cap
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1263:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1263#discussion_r945270934
##########
testing/sensortest/sensortest.c:
##########
@@ -178,6 +180,16 @@ static void print_ppgq(const char *buffer, const char *name)
event->gain[2], event->gain[3]);
}
+static void print_cap(FAR const char *buffer, FAR const char *name)
+{
+ struct sensor_cap *event = (struct sensor_cap *)buffer;
Review Comment:
```suggestion
FAR struct sensor_cap *event = (FAR struct sensor_cap *)buffer;
```
But I see that many places across the file are not equipped with FAR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1263: fix: sensor: add sensor type of cap
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1263:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1263#discussion_r945276443
##########
testing/sensortest/sensortest.c:
##########
@@ -178,6 +180,16 @@ static void print_ppgq(const char *buffer, const char *name)
event->gain[2], event->gain[3]);
}
+static void print_cap(FAR const char *buffer, FAR const char *name)
+{
+ struct sensor_cap *event = (struct sensor_cap *)buffer;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org