[GitHub] [accumulo] dlmarion commented on a change in pull request #2590: Change location where Thread.start() is called to resolve ErrorProne warning

[GitBox <gi...@apache.org>]

dlmarion commented on a change in pull request #2590:
URL: https://github.com/apache/accumulo/pull/2590#discussion_r840511193



##########
File path: core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftTransportPool.java
##########
@@ -836,7 +834,7 @@ public synchronized void setIdleTime(long time) {
   }
 
   void startCheckerThread() {
-    checkThreadFactory.get();
+    checkThreadFactory.get().start();

Review comment:
       > If start is called here, and this method is only called once, I'm not sure there's any point in having it memoized anymore.
   
   I agree this could be changed further. This method is only called from ClientContext.getTransportPool, and it's only called once.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org