You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "Frederik Boster (Jira)" <ji...@apache.org> on 2021/02/26 12:02:00 UTC

[jira] [Commented] (MGPG-81) GPGVersion.compareTo misuses IllegalArgumentException

    [ https://issues.apache.org/jira/browse/MGPG-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291603#comment-17291603 ] 

Frederik Boster commented on MGPG-81:
-------------------------------------

I submitted a proposal in [PR #11|https://github.com/apache/maven-gpg-plugin/pull/11], which moves the parsing logic and therefore the IllegalArgumentException from "GpgVersion#compareTo" to "GpgVersion#parse", which should make the usage of IllegalArgumentException semantically correct.

> GPGVersion.compareTo misuses IllegalArgumentException 
> ------------------------------------------------------
>
>                 Key: MGPG-81
>                 URL: https://issues.apache.org/jira/browse/MGPG-81
>             Project: Maven GPG Plugin
>          Issue Type: Bug
>            Reporter: Elliotte Rusty Harold
>            Priority: Major
>
> It throws IllegalArgumentException for problems not related to the argument of the method. These should be thrown by the constructor where the argument is passed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)