[GitHub] [spark] itholic commented on a diff in pull request #42270: [SPARK-43567][PS] Support `use_na_sentinel` for `factorize`

["itholic (via GitHub)" <gi...@apache.org>]

itholic commented on code in PR #42270:
URL: https://github.com/apache/spark/pull/42270#discussion_r1281260888


##########
python/pyspark/pandas/base.py:
##########
@@ -1625,11 +1625,10 @@ def factorize(
         Parameters
         ----------
         sort : bool, default True
-        na_sentinel : int or None, default -1
-            Value to mark "not found". If None, will not drop the NaN
-            from the uniques of the values.
-
-            .. deprecated:: 3.4.0
+        use_na_sentinel : bool, default True

Review Comment:
   Updated. Thanks for the suggestion!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org