[GitHub] [druid] jon-wei commented on a change in pull request #9384: Add join prefix duplicate/shadowing check

[GitBox <gi...@apache.org>]

jon-wei commented on a change in pull request #9384: Add join prefix duplicate/shadowing check
URL: https://github.com/apache/druid/pull/9384#discussion_r383607739
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/segment/join/HashJoinSegmentStorageAdapter.java
 ##########
 @@ -56,25 +56,29 @@
   private final List<JoinableClause> clauses;
   private final boolean enableFilterPushDown;
 
+  /**
+   * @param baseAdapter A StorageAdapter for the left-hand side base segment
+   * @param clauses The right-hand side clauses. The caller is responsible for ensuring that there are no
+   *                duplicate prefixes or prefixes that shadow each other across the clauses
+   * @param enableFilterPushDown Whether to enable filter push down optimizations to the base segment
+   */
   HashJoinSegmentStorageAdapter(
       StorageAdapter baseAdapter,
-      List<JoinableClause> clauses
+      List<JoinableClause> clauses,
+      final boolean enableFilterPushDown
   )
   {
     this.baseAdapter = baseAdapter;
     this.clauses = clauses;
-    this.enableFilterPushDown = QueryContexts.DEFAULT_ENABLE_JOIN_FILTER_PUSH_DOWN;
+    this.enableFilterPushDown = enableFilterPushDown;
   }
 
   HashJoinSegmentStorageAdapter(
 
 Review comment:
   Added annotation

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org