You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by to...@apache.org on 2011/12/12 21:45:31 UTC
svn commit: r1213432 - /hadoop/common/trunk/dev-support/test-patch.sh
Author: tomwhite
Date: Mon Dec 12 20:45:30 2011
New Revision: 1213432
URL: http://svn.apache.org/viewvc?rev=1213432&view=rev
Log:
HADOOP-7912. test-patch should run eclipse:eclipse to verify that it does not break again. Contributed by Robert Joseph Evans
Modified:
hadoop/common/trunk/dev-support/test-patch.sh
Modified: hadoop/common/trunk/dev-support/test-patch.sh
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/dev-support/test-patch.sh?rev=1213432&r1=1213431&r2=1213432&view=diff
==============================================================================
--- hadoop/common/trunk/dev-support/test-patch.sh (original)
+++ hadoop/common/trunk/dev-support/test-patch.sh Mon Dec 12 20:45:30 2011
@@ -586,6 +586,35 @@ $JIRA_COMMENT_FOOTER"
}
###############################################################################
+### Verify eclipse:eclipse works
+checkEclipseGeneration () {
+ echo ""
+ echo ""
+ echo "======================================================================"
+ echo "======================================================================"
+ echo " Running mvn eclipse:eclipse."
+ echo "======================================================================"
+ echo "======================================================================"
+ echo ""
+ echo ""
+
+ echo "$MVN eclipse:eclipse -D${PROJECT_NAME}PatchProcess"
+ $MVN eclipse:eclipse -D${PROJECT_NAME}PatchProcess
+ if [[ $? != 0 ]] ; then
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ -1 eclipse:eclipse. The patch failed to build with eclipse:eclipse."
+ return 1
+ fi
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ +1 eclipse:eclipse. The patch built with eclipse:eclipse."
+ return 0
+}
+
+
+
+###############################################################################
### Run the tests
runTests () {
echo ""
@@ -790,6 +819,8 @@ checkJavadocWarnings
(( RESULT = RESULT + $? ))
checkJavacWarnings
(( RESULT = RESULT + $? ))
+checkEclipseGeneration
+(( RESULT = RESULT + $? ))
### Checkstyle not implemented yet
#checkStyle
#(( RESULT = RESULT + $? ))