You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2013/07/12 05:34:27 UTC
[Bug 55249] New: JspC compiles tag files even if compile options is
false
https://issues.apache.org/bugzilla/show_bug.cgi?id=55249
Bug ID: 55249
Summary: JspC compiles tag files even if compile options is
false
Product: Tomcat 8
Version: trunk
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: Jasper
Assignee: dev@tomcat.apache.org
Reporter: jboynes@apache.org
JspC has a option "compile" which determines if the generated .java should be
compiled to .class files. This flag is not honoured when a tag file is
referenced from a JSP. The generated Java is always generated even if this flag
is false.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 55249] JspC compiles tag files even if compile options is false
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55249
--- Comment #4 from Jeremy Boynes <jb...@apache.org> ---
Adding context in case anyone looks at this. This seemed like odd behaviour for
me for someone using JspC. Better would be if JspC either consistently handled
JSP and Tag files - either compiling both or compiling neither.
If it has to have a compiler to handle the tags, then it could use that to go
directly from JSP source to bytecode and eliminate the need to run <javac>
after pre-compilation. However, if someone wanted more control over the
compilation process (e.g. using a different compiler or combining that step
with non-JSP source) then they would want that to apply to both JSP and Tag
code.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: LATER vs WONTFIX, was: [Bug 55249] JspC compiles tag files even
if compile options is false
Posted by Mark Thomas <ma...@apache.org>.
On 10/10/2013 21:41, Jeremy Boynes wrote:
> On Oct 10, 2013, at 12:46 PM, Mark Thomas <ma...@apache.org>
> wrote:
>
>> On 10/10/2013 20:40, Jeremy Boynes wrote:
>>> On Oct 10, 2013, at 7:48 AM, bugzilla@apache.org wrote:
>>>
>>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=55249
>>>>
>>>> Mark Thomas <ma...@apache.org> changed:
>>>>
>>>> What |Removed |Added
>>>> ----------------------------------------------------------------------------
>>>>
>>>>
>>
>>>>
>>>>
Status|NEW |RESOLVED
>>>> Resolution|--- |WONTFIX
>>>
>>> Is LATER a better status for this? I was planning to look in to
>>> this at some point, it's just work has kept me busy the last
>>> few weeks.
>>
>> Obtaining the information required via a route other than
>> compilation is likely to be more expensive that the compilation
>> step. I doubt any patch is worth the effort so WONTFIX seems
>> appropriate. It doesn't prevent a fix at a later date.
>
> This was more for my thinking on Bugzilla status. I think of
> WONTFIX as being "we will never do this because of technical reason
> X so a patch is unlikely to be applied"
Which is where I think we are on this one. Having looked into it, I
viable patch that isn't hugely more complex and expensive than what we
have seems very unlikely.
> vs. LATER being "we have no plans to do this but would consider a
> patch."
Those just tend to get left as open enhancement requests. We don't
really use the LATER status at all.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
LATER vs WONTFIX, was: [Bug 55249] JspC compiles tag files even if compile options is false
Posted by Jeremy Boynes <jb...@apache.org>.
On Oct 10, 2013, at 12:46 PM, Mark Thomas <ma...@apache.org> wrote:
> On 10/10/2013 20:40, Jeremy Boynes wrote:
>> On Oct 10, 2013, at 7:48 AM, bugzilla@apache.org wrote:
>>
>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=55249
>>>
>>> Mark Thomas <ma...@apache.org> changed:
>>>
>>> What |Removed |Added
>>> ----------------------------------------------------------------------------
>>>
>>>
> Status|NEW |RESOLVED
>>> Resolution|--- |WONTFIX
>>
>> Is LATER a better status for this? I was planning to look in to
>> this at some point, it's just work has kept me busy the last few
>> weeks.
>
> Obtaining the information required via a route other than compilation
> is likely to be more expensive that the compilation step. I doubt any
> patch is worth the effort so WONTFIX seems appropriate. It doesn't
> prevent a fix at a later date.
This was more for my thinking on Bugzilla status. I think of WONTFIX as being "we will never do this because of technical reason X so a patch is unlikely to be applied" vs. LATER being "we have no plans to do this but would consider a patch."
Cheers
Jeremy
Re: [Bug 55249] JspC compiles tag files even if compile options is
false
Posted by Mark Thomas <ma...@apache.org>.
On 10/10/2013 20:40, Jeremy Boynes wrote:
> On Oct 10, 2013, at 7:48 AM, bugzilla@apache.org wrote:
>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=55249
>>
>> Mark Thomas <ma...@apache.org> changed:
>>
>> What |Removed |Added
>> ----------------------------------------------------------------------------
>>
>>
Status|NEW |RESOLVED
>> Resolution|--- |WONTFIX
>
> Is LATER a better status for this? I was planning to look in to
> this at some point, it's just work has kept me busy the last few
> weeks.
Obtaining the information required via a route other than compilation
is likely to be more expensive that the compilation step. I doubt any
patch is worth the effort so WONTFIX seems appropriate. It doesn't
prevent a fix at a later date.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [Bug 55249] JspC compiles tag files even if compile options is false
Posted by Jeremy Boynes <jb...@apache.org>.
On Oct 10, 2013, at 7:48 AM, bugzilla@apache.org wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=55249
>
> Mark Thomas <ma...@apache.org> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> Status|NEW |RESOLVED
> Resolution|--- |WONTFIX
Is LATER a better status for this? I was planning to look in to this at some point, it's just work has kept me busy the last few weeks.
Thanks
Jeremy
[Bug 55249] JspC compiles tag files even if compile options is false
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55249
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |WONTFIX
--- Comment #3 from Mark Thomas <ma...@apache.org> ---
I took a look at this but the assumption that tag files are compiled runs
through a considerable portion of the Jasper code. I started to try and
untangle it and got so far (the compilation step, the dependencies) but
building the TagHandlerInfo from source is non-trivial. It could be done but I
am not convinced it is worth doing.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 55249] JspC compiles tag files even if compile options is false
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55249
--- Comment #2 from Jeremy Boynes <jb...@apache.org> ---
Sorry, yes it should.
JspC always attempts to compile the Java source generated for tag files even if
the "compile" option is set "false" to indicate that operation should not be
performed.
The call into the Compiler comes a JspServletWrapper:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java?view=markup#l240
that was created by the TagFileProcessor visiting that node. The value of the
"compile" option is not available at that point of the code and is not passed
in.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 55249] JspC compiles tag files even if compile options is false
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55249
--- Comment #1 from Mark Thomas <ma...@apache.org> ---
The report doesn't make much sense (I haven't looked at the source code to try
and clarify it). I wouldn't expect a compile flag to control whether or not a
.java file is created. Should the last sentence have been "The generated Java
file is always compiled even if this flag is false."?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org