You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by tellison <gi...@git.apache.org> on 2016/07/29 09:21:13 UTC
[GitHub] incubator-pirk pull request #30: Ensure stop list property is set for tests.
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/30
Ensure stop list property is set for tests.
- Now throws a PIR exception if the required property is not set.
- Includes some tidy-up of temp file creation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tellison/incubator-pirk tempfile
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/30.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #30
----
commit 7fa17c9a168fd6c1ff40d5330e95c4746ae06866
Author: Tim Ellison <t....@gmail.com>
Date: 2016-07-29T09:12:24Z
Ensure stop list property is set for tests.
- Now throws a PIR exception if the required property is not set.
- Includes some tidy-up of temp file creation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #30: Ensure stop list property is set for tests.
Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/30
+1
Yes, this property was changed in the last commit. It was building and running just fine for me locally and on the cluster (distributed tests), passed Travis, but Jenkins had issues - thanks for fixing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #30: Ensure stop list property is set for tests.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/30
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #30: Ensure stop list property is set for tests.
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/30
Lgtm +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---