You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Sergey Shelukhin (JIRA)" <ji...@apache.org> on 2012/10/23 03:18:11 UTC
[jira] [Created] (HBASE-7033) Add
hbase.lru.blockcache.acceptable.factor to configuration, akin to the
min.factor added by HBASE-6312
Sergey Shelukhin created HBASE-7033:
---------------------------------------
Summary: Add hbase.lru.blockcache.acceptable.factor to configuration, akin to the min.factor added by HBASE-6312
Key: HBASE-7033
URL: https://issues.apache.org/jira/browse/HBASE-7033
Project: HBase
Issue Type: Improvement
Components: io
Affects Versions: 0.96.0
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Fix For: 0.96.0
Background: we want to make the change to block cache setting available on 0.94 without actually changing the defaults as was done in HBASE-6312, as this can be destabilizing.
Thus, both of these would be configurable instead of just one, and the user would be able to switch to new values.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7033) Add
hbase.lru.blockcache.acceptable.factor to configuration, akin to the
min.factor added by HBASE-6312
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484525#comment-13484525 ]
Hudson commented on HBASE-7033:
-------------------------------
Integrated in HBase-TRUNK #3487 (See [https://builds.apache.org/job/HBase-TRUNK/3487/])
HBASE-7033. Add hbase.lru.blockcache.acceptable.factor to configuration (Sergey Shelukhin) (Revision 1402314)
Result = FAILURE
apurtell :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
> Add hbase.lru.blockcache.acceptable.factor to configuration, akin to the min.factor added by HBASE-6312
> -------------------------------------------------------------------------------------------------------
>
> Key: HBASE-7033
> URL: https://issues.apache.org/jira/browse/HBASE-7033
> Project: HBase
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7033.patch
>
>
> Background: we want to make the change to block cache setting available on 0.94 without actually changing the defaults as was done in HBASE-6312, as this can be destabilizing.
> Thus, both of these would be configurable instead of just one, and the user would be able to switch to new values.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7033) Add
hbase.lru.blockcache.acceptable.factor to configuration, akin to the
min.factor added by HBASE-6312
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484439#comment-13484439 ]
Andrew Purtell commented on HBASE-7033:
---------------------------------------
+1 for commit. Trivial change, looks clean. Going to just go ahead and do this in a few minutes.
> Add hbase.lru.blockcache.acceptable.factor to configuration, akin to the min.factor added by HBASE-6312
> -------------------------------------------------------------------------------------------------------
>
> Key: HBASE-7033
> URL: https://issues.apache.org/jira/browse/HBASE-7033
> Project: HBase
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7033.patch
>
>
> Background: we want to make the change to block cache setting available on 0.94 without actually changing the defaults as was done in HBASE-6312, as this can be destabilizing.
> Thus, both of these would be configurable instead of just one, and the user would be able to switch to new values.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7033) Add
hbase.lru.blockcache.acceptable.factor to configuration, akin to the
min.factor added by HBASE-6312
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483523#comment-13483523 ]
Sergey Shelukhin commented on HBASE-7033:
-----------------------------------------
wondering if someone could review this...
> Add hbase.lru.blockcache.acceptable.factor to configuration, akin to the min.factor added by HBASE-6312
> -------------------------------------------------------------------------------------------------------
>
> Key: HBASE-7033
> URL: https://issues.apache.org/jira/browse/HBASE-7033
> Project: HBase
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7033.patch
>
>
> Background: we want to make the change to block cache setting available on 0.94 without actually changing the defaults as was done in HBASE-6312, as this can be destabilizing.
> Thus, both of these would be configurable instead of just one, and the user would be able to switch to new values.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7033) Add
hbase.lru.blockcache.acceptable.factor to configuration, akin to the
min.factor added by HBASE-6312
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484597#comment-13484597 ]
Hudson commented on HBASE-7033:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #237 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/237/])
HBASE-7033. Add hbase.lru.blockcache.acceptable.factor to configuration (Sergey Shelukhin) (Revision 1402314)
Result = FAILURE
apurtell :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
> Add hbase.lru.blockcache.acceptable.factor to configuration, akin to the min.factor added by HBASE-6312
> -------------------------------------------------------------------------------------------------------
>
> Key: HBASE-7033
> URL: https://issues.apache.org/jira/browse/HBASE-7033
> Project: HBase
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7033.patch
>
>
> Background: we want to make the change to block cache setting available on 0.94 without actually changing the defaults as was done in HBASE-6312, as this can be destabilizing.
> Thus, both of these would be configurable instead of just one, and the user would be able to switch to new values.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7033) Add
hbase.lru.blockcache.acceptable.factor to configuration, akin to the
min.factor added by HBASE-6312
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Shelukhin updated HBASE-7033:
------------------------------------
Status: Patch Available (was: Open)
> Add hbase.lru.blockcache.acceptable.factor to configuration, akin to the min.factor added by HBASE-6312
> -------------------------------------------------------------------------------------------------------
>
> Key: HBASE-7033
> URL: https://issues.apache.org/jira/browse/HBASE-7033
> Project: HBase
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7033.patch
>
>
> Background: we want to make the change to block cache setting available on 0.94 without actually changing the defaults as was done in HBASE-6312, as this can be destabilizing.
> Thus, both of these would be configurable instead of just one, and the user would be able to switch to new values.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7033) Add
hbase.lru.blockcache.acceptable.factor to configuration, akin to the
min.factor added by HBASE-6312
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482212#comment-13482212 ]
Hadoop QA commented on HBASE-7033:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12550401/HBASE-7033.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 82 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3123//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3123//console
This message is automatically generated.
> Add hbase.lru.blockcache.acceptable.factor to configuration, akin to the min.factor added by HBASE-6312
> -------------------------------------------------------------------------------------------------------
>
> Key: HBASE-7033
> URL: https://issues.apache.org/jira/browse/HBASE-7033
> Project: HBase
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7033.patch
>
>
> Background: we want to make the change to block cache setting available on 0.94 without actually changing the defaults as was done in HBASE-6312, as this can be destabilizing.
> Thus, both of these would be configurable instead of just one, and the user would be able to switch to new values.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7033) Add
hbase.lru.blockcache.acceptable.factor to configuration, akin to the
min.factor added by HBASE-6312
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Shelukhin updated HBASE-7033:
------------------------------------
Attachment: HBASE-7033.patch
> Add hbase.lru.blockcache.acceptable.factor to configuration, akin to the min.factor added by HBASE-6312
> -------------------------------------------------------------------------------------------------------
>
> Key: HBASE-7033
> URL: https://issues.apache.org/jira/browse/HBASE-7033
> Project: HBase
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7033.patch
>
>
> Background: we want to make the change to block cache setting available on 0.94 without actually changing the defaults as was done in HBASE-6312, as this can be destabilizing.
> Thus, both of these would be configurable instead of just one, and the user would be able to switch to new values.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7033) Add
hbase.lru.blockcache.acceptable.factor to configuration, akin to the
min.factor added by HBASE-6312
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484708#comment-13484708 ]
Hudson commented on HBASE-7033:
-------------------------------
Integrated in HBase-0.94 #555 (See [https://builds.apache.org/job/HBase-0.94/555/])
HBASE-7053 port blockcache configurability (part of HBASE-6312, and HBASE-7033) to 0.94 (Sergey Shelukhin) (Revision 1402385)
Result = SUCCESS
larsh :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileDataBlockEncoder.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java
> Add hbase.lru.blockcache.acceptable.factor to configuration, akin to the min.factor added by HBASE-6312
> -------------------------------------------------------------------------------------------------------
>
> Key: HBASE-7033
> URL: https://issues.apache.org/jira/browse/HBASE-7033
> Project: HBase
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7033.patch
>
>
> Background: we want to make the change to block cache setting available on 0.94 without actually changing the defaults as was done in HBASE-6312, as this can be destabilizing.
> Thus, both of these would be configurable instead of just one, and the user would be able to switch to new values.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7033) Add
hbase.lru.blockcache.acceptable.factor to configuration, akin to the
min.factor added by HBASE-6312
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482673#comment-13482673 ]
Sergey Shelukhin commented on HBASE-7033:
-----------------------------------------
[~enis] Can you please take a look?
> Add hbase.lru.blockcache.acceptable.factor to configuration, akin to the min.factor added by HBASE-6312
> -------------------------------------------------------------------------------------------------------
>
> Key: HBASE-7033
> URL: https://issues.apache.org/jira/browse/HBASE-7033
> Project: HBase
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7033.patch
>
>
> Background: we want to make the change to block cache setting available on 0.94 without actually changing the defaults as was done in HBASE-6312, as this can be destabilizing.
> Thus, both of these would be configurable instead of just one, and the user would be able to switch to new values.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7033) Add
hbase.lru.blockcache.acceptable.factor to configuration, akin to the
min.factor added by HBASE-6312
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-7033:
----------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for the patch Sergey!
> Add hbase.lru.blockcache.acceptable.factor to configuration, akin to the min.factor added by HBASE-6312
> -------------------------------------------------------------------------------------------------------
>
> Key: HBASE-7033
> URL: https://issues.apache.org/jira/browse/HBASE-7033
> Project: HBase
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7033.patch
>
>
> Background: we want to make the change to block cache setting available on 0.94 without actually changing the defaults as was done in HBASE-6312, as this can be destabilizing.
> Thus, both of these would be configurable instead of just one, and the user would be able to switch to new values.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7033) Add
hbase.lru.blockcache.acceptable.factor to configuration, akin to the
min.factor added by HBASE-6312
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490385#comment-13490385 ]
Hudson commented on HBASE-7033:
-------------------------------
Integrated in HBase-0.94-security-on-Hadoop-23 #9 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/9/])
HBASE-7053 port blockcache configurability (part of HBASE-6312, and HBASE-7033) to 0.94 (Sergey Shelukhin) (Revision 1402385)
Result = FAILURE
larsh :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileDataBlockEncoder.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java
> Add hbase.lru.blockcache.acceptable.factor to configuration, akin to the min.factor added by HBASE-6312
> -------------------------------------------------------------------------------------------------------
>
> Key: HBASE-7033
> URL: https://issues.apache.org/jira/browse/HBASE-7033
> Project: HBase
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7033.patch
>
>
> Background: we want to make the change to block cache setting available on 0.94 without actually changing the defaults as was done in HBASE-6312, as this can be destabilizing.
> Thus, both of these would be configurable instead of just one, and the user would be able to switch to new values.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira