[GitHub] [pulsar] tisonkun commented on a diff in pull request #20259: [fix][io] add protobuf ByteString to pulsar-io jdbc core

["tisonkun (via GitHub)" <gi...@apache.org>]

tisonkun commented on code in PR #20259:
URL: https://github.com/apache/pulsar/pull/20259#discussion_r1187566110


##########
pulsar-io/jdbc/core/pom.xml:
##########
@@ -58,6 +58,13 @@
       <groupId>com.fasterxml.jackson.dataformat</groupId>
       <artifactId>jackson-dataformat-yaml</artifactId>
     </dependency>
+
+    <dependency>
+      <groupId>com.google.protobuf</groupId>
+      <artifactId>protobuf-java</artifactId>
+      <version>3.22.4</version>

Review Comment:
   Let's use the version in `dependencyManagement` in parent pom.
   
   Also, cloud we use `provided` scope? (N.B. I don't take a considerate thought).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org