You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/04/04 18:57:40 UTC
Re: Review Request 57667: Added executor authentication to the docs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57667/
-----------------------------------------------------------
(Updated April 4, 2017, 6:57 p.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Bugs: MESOS-7005
https://issues.apache.org/jira/browse/MESOS-7005
Repository: mesos
Description
-------
Added executor authentication to the docs.
Diffs
-----
docs/authentication.md 1574db981d5f8ddd7d1f6bef1c2b032823d17297
docs/executor-http-api.md d666d3c459540df9490d7f67b0e43323957d5025
Diff: https://reviews.apache.org/r/57667/diff/7/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 57667: Added executor authentication to the docs.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57667/#review171031
-----------------------------------------------------------
docs/authentication.md
Lines 120 (patched)
<https://reviews.apache.org/r/57667/#comment243866>
Maybe also explicitly note that, command executor and custom executors not using HTTP API (i.e., driver based) are still allowed to register without authentication?
docs/authentication.md
Lines 145 (patched)
<https://reviews.apache.org/r/57667/#comment243863>
s/command/HTTP command/
docs/authentication.md
Lines 146 (patched)
<https://reviews.apache.org/r/57667/#comment243864>
s/custom/custom HTTP/
docs/authentication.md
Lines 148 (patched)
<https://reviews.apache.org/r/57667/#comment243865>
s/executor/HTTP executor/
- Vinod Kone
On April 4, 2017, 6:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57667/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 6:57 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-7005
> https://issues.apache.org/jira/browse/MESOS-7005
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added executor authentication to the docs.
>
>
> Diffs
> -----
>
> docs/authentication.md 1574db981d5f8ddd7d1f6bef1c2b032823d17297
> docs/executor-http-api.md d666d3c459540df9490d7f67b0e43323957d5025
>
>
> Diff: https://reviews.apache.org/r/57667/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 57667: Added executor authentication to the docs.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57667/#review171293
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 5, 2017, 10:37 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57667/
> -----------------------------------------------------------
>
> (Updated April 5, 2017, 10:37 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-7005
> https://issues.apache.org/jira/browse/MESOS-7005
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added executor authentication to the docs.
>
>
> Diffs
> -----
>
> docs/authentication.md 279e00a513d386eb6215a4e6d66652a0af3ec56d
> docs/executor-http-api.md c49c234d73ece925297051b8d07fbe48e47868e0
>
>
> Diff: https://reviews.apache.org/r/57667/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 57667: Added executor authentication to the docs.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57667/
-----------------------------------------------------------
(Updated April 5, 2017, 10:37 p.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Bugs: MESOS-7005
https://issues.apache.org/jira/browse/MESOS-7005
Repository: mesos
Description
-------
Added executor authentication to the docs.
Diffs (updated)
-----
docs/authentication.md 279e00a513d386eb6215a4e6d66652a0af3ec56d
docs/executor-http-api.md c49c234d73ece925297051b8d07fbe48e47868e0
Diff: https://reviews.apache.org/r/57667/diff/8/
Changes: https://reviews.apache.org/r/57667/diff/7-8/
Testing
-------
Thanks,
Greg Mann