You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/01 09:14:12 UTC

[GitHub] [flink] beyond1920 commented on a change in pull request #15003: [FLINK-21482][table-planner-blink] Support grouping set syntax for WindowAggregate

beyond1920 commented on a change in pull request #15003:
URL: https://github.com/apache/flink/pull/15003#discussion_r584549614



##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/agg/WindowAggregateTest.scala
##########
@@ -683,4 +682,165 @@ class WindowAggregateTest extends TableTestBase {
       "must be an integral multiple of step, but got maxSize 3600000 ms and step 1500000 ms")
     util.verifyExplain(sql)
   }
+
+  @Test

Review comment:
       Sorry for forget those case. Already add tests for `cube`,`rollup`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org