You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "ankane (via GitHub)" <gi...@apache.org> on 2023/05/03 22:14:35 UTC
[GitHub] [datasketches-cpp] ankane opened a new issue, #370: One more instance of std::iterator deprecation warning in 4.1.0
ankane opened a new issue, #370:
URL: https://github.com/apache/datasketches-cpp/issues/370
Hi, thanks for this library!
Just upgraded to 4.1.0 and found one more instance of inheritance from `std::iterator` (re #328 and #342).
```text
/Users/runner/work/datasketches-ruby/datasketches-ruby/vendor/datasketches-cpp/theta/include/theta_sketch.hpp:474:82: warning: 'iterator<std::input_iterator_tag, unsigned long long>' is deprecated [-Wdeprecated-declarations]
class wrapped_compact_theta_sketch_alloc<Allocator>::const_iterator: public std::iterator<std::input_iterator_tag, uint64_t> {
^
/Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__iterator/iterator.h:27:29: note: 'iterator<std::input_iterator_tag, unsigned long long>' has been explicitly marked deprecated here
struct _LIBCPP_TEMPLATE_VIS _LIBCPP_DEPRECATED_IN_CXX17 iterator
^
/Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__config:1066:39: note: expanded from macro '_LIBCPP_DEPRECATED_IN_CXX17'
# define _LIBCPP_DEPRECATED_IN_CXX17 _LIBCPP_DEPRECATED
^
/Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__config:1043:48: note: expanded from macro '_LIBCPP_DEPRECATED'
# define _LIBCPP_DEPRECATED __attribute__ ((deprecated))
^
1 warning generated.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] ankane closed issue #370: One more instance of std::iterator deprecation warning in 4.1.0
Posted by "ankane (via GitHub)" <gi...@apache.org>.
ankane closed issue #370: One more instance of std::iterator deprecation warning in 4.1.0
URL: https://github.com/apache/datasketches-cpp/issues/370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin commented on issue #370: One more instance of std::iterator deprecation warning in 4.1.0
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin commented on issue #370:
URL: https://github.com/apache/datasketches-cpp/issues/370#issuecomment-1536848680
Fix is merged. We're trying to decide if we need a 4.1.1 patch release or if it's ok to live with this as a warning until 4.2.0 (which has received no planning).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin commented on issue #370: One more instance of std::iterator deprecation warning in 4.1.0
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin commented on issue #370:
URL: https://github.com/apache/datasketches-cpp/issues/370#issuecomment-1533867852
D'oh! Thanks for catching this. I thought we'd checked all of them!
ðŸ˜
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] ankane commented on issue #370: One more instance of std::iterator deprecation warning in 4.1.0
Posted by "ankane (via GitHub)" <gi...@apache.org>.
ankane commented on issue #370:
URL: https://github.com/apache/datasketches-cpp/issues/370#issuecomment-1536860212
Great, thanks @jmalkin! No strong opinion on a release (fwiw).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org