You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bert Huijben <be...@qqmail.nl> on 2010/03/03 17:35:26 UTC
RE: svn commit: r918542 - in /subversion/trunk/subversion/libsvn_wc: entries.c entries.h log.c old-and-busted.c update_editor.c wc-queries.sql wc_db.c wc_db.h
> -----Original Message-----
> From: Greg Stein [mailto:gstein@gmail.com]
> Sent: woensdag 3 maart 2010 17:22
> To: dev@subversion.apache.org
> Subject: Re: svn commit: r918542 - in
> /subversion/trunk/subversion/libsvn_wc: entries.c entries.h log.c old-and-
> busted.c update_editor.c wc-queries.sql wc_db.c wc_db.h
>
> Please revert.
>
> The atts_to_entry stuff for the CMT_AUTHOR and friends needs to
> remain. That is how we load old entries files.
Yes, the ones in old-and-busted.c, but I didn't remove those; see the diff.
(That flag which keeps track of what is modified there, is ignored for about
a year there).
I just set the update flag to 0 there, like we did for similar changes. I
just removed the write ones in svn_wc__loggy_entry_modify, as we are no
longer writing them in the log.
When we are reading the entire entry (like on upgrades) the code still works
as before.
Bert
RE: RE: svn commit: r918542 - in /subversion/trunk/subversion/libsvn_wc: entries.c entries.h log.c old-and-busted.c update_editor.c wc-queries.sql wc_db.c wc_db.h
Posted by Bert Huijben <be...@qqmail.nl>.
Thanks,
(I think I add some very very old working copy later tonight to
automatically check what you were afraid of :))
Have a good flight!
Bert
From: Greg Stein [mailto:gstein@gmail.com]
Sent: woensdag 3 maart 2010 18:40
To: Bert Huijben
Cc: dev@subversion.apache.org
Subject: Re: RE: svn commit: r918542 - in
/subversion/trunk/subversion/libsvn_wc: entries.c entries.h log.c
old-and-busted.c update_editor.c wc-queries.sql wc_db.c wc_db.h
Hrm. Okee... sorry then; I'll review in solid detail after plane flight,
when I'm back to my laptop.
On Mar 3, 2010 9:35 AM, "Bert Huijben" <be...@qqmail.nl> wrote:
> -----Original Message-----
> From: Greg Stein [mailto:gstein@gmail.com]
> Sent: woensdag 3 maart...
Yes, the ones in old-and-busted.c, but I didn't remove those; see the diff.
(That flag which keeps track of what is modified there, is ignored for about
a year there).
I just set the update flag to 0 there, like we did for similar changes. I
just removed the write ones in svn_wc__loggy_entry_modify, as we are no
longer writing them in the log.
When we are reading the entire entry (like on upgrades) the code still works
as before.
Bert
Re: RE: svn commit: r918542 - in /subversion/trunk/subversion/libsvn_wc:
entries.c entries.h log.c old-and-busted.c update_editor.c wc-queries.sql
wc_db.c wc_db.h
Posted by Greg Stein <gs...@gmail.com>.
Hrm. Okee... sorry then; I'll review in solid detail after plane flight,
when I'm back to my laptop.
On Mar 3, 2010 9:35 AM, "Bert Huijben" <be...@qqmail.nl> wrote:
> -----Original Message-----
> From: Greg Stein [mailto:gstein@gmail.com]
> Sent: woensdag 3 maart...
Yes, the ones in old-and-busted.c, but I didn't remove those; see the diff.
(That flag which keeps track of what is modified there, is ignored for about
a year there).
I just set the update flag to 0 there, like we did for similar changes. I
just removed the write ones in svn_wc__loggy_entry_modify, as we are no
longer writing them in the log.
When we are reading the entire entry (like on upgrades) the code still works
as before.
Bert