[GitHub] [netbeans] neilcsmith-net commented on a diff in pull request #4785: enable branch protection for master.

[GitBox <gi...@apache.org>]

neilcsmith-net commented on code in PR #4785:
URL: https://github.com/apache/netbeans/pull/4785#discussion_r995808141


##########
.asf.yaml:
##########
@@ -31,6 +33,23 @@ github:
     squash:  true
     merge:   true
     rebase:  true
+  protected_branches:
+    # no force push to master
+    master:
+#      required_pull_request_reviews:
+#        required_approving_review_count: 1
+#        dismiss_stale_reviews: false
+      required_status_checks:
+          # strict means "Require branches to be up to date before merging".
+          strict: false
+          # list of names of checks that must pass
+#          contexts:
+#            - Commit Validation on Linux/JDK 11

Review Comment:
   Ah, OK, your meta-job comment now makes sense to me!  Mind you, we should possibly do some basic paperwork checks (eg. commit info) for all merged PRs? `ci:no-build` could mean skip the build and dependent checks rather than no actions at all?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists