You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/07/31 15:42:48 UTC
[GitHub] [hudi] n3nash opened a new pull request #1894: [WIP] Suppressing spark logs for hudi-integ and hudi-utilities
n3nash opened a new pull request #1894:
URL: https://github.com/apache/hudi/pull/1894
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar merged pull request #1894: [MINOR] Suppressing spark logs for hudi-integ and hudi-utilities
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1894:
URL: https://github.com/apache/hudi/pull/1894
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #1894: [WIP] Suppressing spark logs for hudi-integ and hudi-utilities
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1894:
URL: https://github.com/apache/hudi/pull/1894#discussion_r463724384
##########
File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestBase.java
##########
@@ -132,6 +134,12 @@ public void init() {
await().atMost(60, SECONDS).until(this::servicesUp);
}
+ private void suppressSparkLogs() {
Review comment:
this may not have that much impact. given we don't kick off any Spark DAGs from this java class. its all done via commands passes to docker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #1894: [WIP] Suppressing spark logs for hudi-integ and hudi-utilities
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1894:
URL: https://github.com/apache/hudi/pull/1894#discussion_r463903236
##########
File path: docker/demo/setup_demo_container.sh
##########
@@ -17,6 +17,7 @@
echo "Copying spark default config and setting up configs"
cp /var/hoodie/ws/docker/demo/config/spark-defaults.conf $SPARK_CONF_DIR/.
+cp /var/hoodie/ws/docker/demo/config/log4j.properties $SPARK_CONF_DIR/.
Review comment:
sweet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #1894: [WIP] Suppressing spark logs for hudi-integ and hudi-utilities
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1894:
URL: https://github.com/apache/hudi/pull/1894#discussion_r463782211
##########
File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestBase.java
##########
@@ -31,6 +31,7 @@
import com.github.dockerjava.core.DockerClientConfig;
import com.github.dockerjava.core.command.ExecStartResultCallback;
import com.github.dockerjava.jaxrs.JerseyDockerCmdExecFactory;
+import org.apache.log4j.Level;
Review comment:
is this still used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #1894: [WIP] Suppressing spark logs for hudi-integ and hudi-utilities
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #1894:
URL: https://github.com/apache/hudi/pull/1894#issuecomment-667228852
if you see, https://api.travis-ci.org/v3/job/713740328/log.txt you will find logs for Spark deltastreamer (the actual code, not tests). I think we can pass the log4J.properties when we kick off the deltastreamer from ITTHoodieDemo here? https://github.com/apache/hudi/blob/master/hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestHoodieDemo.java#L135
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org