You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "DaanHoogland (via GitHub)" <gi...@apache.org> on 2025/09/22 13:17:38 UTC
[PR] LDAP: honour nested groups for MSAD [cloudstack]
DaanHoogland opened a new pull request, #11696:
URL: https://github.com/apache/cloudstack/pull/11696
### Description
This PR makes sure the right memberOf attribute is retrieved in the case of MSAD ...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
Fixes: #10278
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#discussion_r2374610871
##########
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java:
##########
@@ -93,10 +93,14 @@ protected boolean isUserDisabled(SearchResult result) throws NamingException {
}
protected String getMemberOfAttribute(final Long domainId) {
+ String rc;
if(_ldapConfiguration.isNestedGroupsEnabled(domainId)) {
- return MICROSOFT_AD_NESTED_MEMBERS_FILTER;
+ rc = MICROSOFT_AD_NESTED_MEMBERS_FILTER;
} else {
- return MICROSOFT_AD_MEMBERS_FILTER;
+ rc = MICROSOFT_AD_MEMBERS_FILTER;
}
+ logger.debug("memberOf filter = " + rc);
Review Comment:
yes @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#issuecomment-3318977389
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#issuecomment-3322626104
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#discussion_r2371289010
##########
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/OpenLdapUserManagerImpl.java:
##########
@@ -87,7 +87,7 @@ private String generateSearchFilter(final String username, Long domainId) {
usernameFilter.append((username == null ? "*" : LdapUtils.escapeLDAPSearchFilter(username)));
usernameFilter.append(")");
- String memberOfAttribute = _ldapConfiguration.getUserMemberOfAttribute(domainId);
+ String memberOfAttribute = getMemberOfAttribute(domainId);
Review Comment:
@DaanHoogland
there is a method in the same file
```
protected String getMemberOfAttribute(final Long domainId) {
return _ldapConfiguration.getUserMemberOfAttribute(domainId);
}
```
which is used only once
```
if ("GROUP".equals(type)) {
memberOfFilter.append("(").append(getMemberOfAttribute(domainId)).append("=");
memberOfFilter.append(name);
memberOfFilter.append(")");
}
```
is it correct ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#discussion_r2374652940
##########
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/OpenLdapUserManagerImpl.java:
##########
@@ -87,7 +87,7 @@ private String generateSearchFilter(final String username, Long domainId) {
usernameFilter.append((username == null ? "*" : LdapUtils.escapeLDAPSearchFilter(username)));
usernameFilter.append(")");
- String memberOfAttribute = _ldapConfiguration.getUserMemberOfAttribute(domainId);
+ String memberOfAttribute = getMemberOfAttribute(domainId);
Review Comment:
yes, but it is overloaded in the AD user manager, so at this point it is not known which one will be called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#issuecomment-3319307069
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11696?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.54545%` with `5 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 18.44%. Comparing base ([`0cbebbd`](https://app.codecov.io/gh/apache/cloudstack/commit/0cbebbddddab9944747cc57773f79a0dcfbd81ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bde238a`](https://app.codecov.io/gh/apache/cloudstack/commit/bde238af952e38e4a0131c1957963a5c41cecc63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 317 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/cloudstack/pull/11696?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...pache/cloudstack/ldap/OpenLdapUserManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/11696?src=pr&el=tree&filepath=plugins%2Fuser-authenticators%2Fldap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fldap%2FOpenLdapUserManagerImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy91c2VyLWF1dGhlbnRpY2F0b3JzL2xkYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbGRhcC9PcGVuTGRhcFVzZXJNYW5hZ2VySW1wbC5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/11696?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...src/main/java/com/cloud/server/StatsCollector.java](https://app.codecov.io/gh/apache/cloudstack/pull/11696?src=pr&el=tree&filepath=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fserver%2FStatsCollector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3NlcnZlci9TdGF0c0NvbGxlY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/11696?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/cloudstack/ldap/LdapConfiguration.java](https://app.codecov.io/gh/apache/cloudstack/pull/11696?src=pr&el=tree&filepath=plugins%2Fuser-authenticators%2Fldap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fldap%2FLdapConfiguration.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy91c2VyLWF1dGhlbnRpY2F0b3JzL2xkYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbGRhcC9MZGFwQ29uZmlndXJhdGlvbi5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/11696?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #11696 +/- ##
============================================
+ Coverage 16.17% 18.44% +2.26%
- Complexity 13297 15282 +1985
============================================
Files 5656 5449 -207
Lines 498151 489043 -9108
Branches 60441 57425 -3016
============================================
+ Hits 80588 90196 +9608
+ Misses 408591 388665 -19926
- Partials 8972 10182 +1210
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11696/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11696/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11696/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `18.44% <54.54%> (+1.41%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11696?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#issuecomment-3325951353
<b>[SF] Trillian test result (tid-14424)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53795 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11696-t14424-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#issuecomment-3322906998
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#issuecomment-3322912195
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#issuecomment-3327107106
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#issuecomment-3327345587
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#discussion_r2374586400
##########
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java:
##########
@@ -93,10 +93,14 @@ protected boolean isUserDisabled(SearchResult result) throws NamingException {
}
protected String getMemberOfAttribute(final Long domainId) {
+ String rc;
if(_ldapConfiguration.isNestedGroupsEnabled(domainId)) {
- return MICROSOFT_AD_NESTED_MEMBERS_FILTER;
+ rc = MICROSOFT_AD_NESTED_MEMBERS_FILTER;
} else {
- return MICROSOFT_AD_MEMBERS_FILTER;
+ rc = MICROSOFT_AD_MEMBERS_FILTER;
}
+ logger.debug("memberOf filter = " + rc);
Review Comment:
it is debug message to ensure the AD provider is used and in the right way.
We could remove or make it trace.
the only detail to add at this point is the domainid.
```suggestion
logger.trace(“using memberOf filter = {} for domain with id {}”, rc, domainId);
```
Is that what you mean, @weizhouapache ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#discussion_r2374652940
##########
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/OpenLdapUserManagerImpl.java:
##########
@@ -87,7 +87,7 @@ private String generateSearchFilter(final String username, Long domainId) {
usernameFilter.append((username == null ? "*" : LdapUtils.escapeLDAPSearchFilter(username)));
usernameFilter.append(")");
- String memberOfAttribute = _ldapConfiguration.getUserMemberOfAttribute(domainId);
+ String memberOfAttribute = getMemberOfAttribute(domainId);
Review Comment:
yes, but it is overloaded in the AD provider so at this point it is not known which one will be called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#issuecomment-3322513932
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#issuecomment-3322626144
@DaanHoogland
I changed the target branch from main to 4.20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#issuecomment-3322400879
@rajujith a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache merged PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#issuecomment-3322624227
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#issuecomment-3327112801
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#issuecomment-3322827192
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#issuecomment-3327429096
Merging based on approvals and test
thanks @DaanHoogland @rajujith
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#discussion_r2374859707
##########
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java:
##########
@@ -93,10 +93,14 @@ protected boolean isUserDisabled(SearchResult result) throws NamingException {
}
protected String getMemberOfAttribute(final Long domainId) {
+ String rc;
if(_ldapConfiguration.isNestedGroupsEnabled(domainId)) {
- return MICROSOFT_AD_NESTED_MEMBERS_FILTER;
+ rc = MICROSOFT_AD_NESTED_MEMBERS_FILTER;
} else {
- return MICROSOFT_AD_MEMBERS_FILTER;
+ rc = MICROSOFT_AD_MEMBERS_FILTER;
}
+ logger.trace(“using memberOf filter = {} for domain with id {}”, rc, domainId);
Review Comment:
```suggestion
logger.trace("using memberOf filter = {} for domain with id {}", rc, domainId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "rajujith (via GitHub)" <gi...@apache.org>.
rajujith commented on PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#issuecomment-3322399295
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LDAP: honour nested groups for MSAD [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#discussion_r2371290266
##########
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java:
##########
@@ -93,10 +93,14 @@ protected boolean isUserDisabled(SearchResult result) throws NamingException {
}
protected String getMemberOfAttribute(final Long domainId) {
+ String rc;
if(_ldapConfiguration.isNestedGroupsEnabled(domainId)) {
- return MICROSOFT_AD_NESTED_MEMBERS_FILTER;
+ rc = MICROSOFT_AD_NESTED_MEMBERS_FILTER;
} else {
- return MICROSOFT_AD_MEMBERS_FILTER;
+ rc = MICROSOFT_AD_MEMBERS_FILTER;
}
+ logger.debug("memberOf filter = " + rc);
Review Comment:
it this debugging message needed ? if yes, can we add more details ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org