You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "charlesweng (via GitHub)" <gi...@apache.org> on 2024/06/02 02:47:05 UTC
[PR] allow users to add description to private gateway and static routes [cloudstack]
charlesweng opened a new pull request, #9135:
URL: https://github.com/apache/cloudstack/pull/9135
### Description
Adding a description to the private gateway tab inside the Network > Vpc > Private Gateway tab. This allows for administrators to easily identify what the private gateway is used for or pertains to.
Backend functionality is also added into the NetworkVO as well as the API interface in java.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
<img width="861" alt="image" src="https://github.com/apache/cloudstack/assets/3377418/c7045ca2-a55f-4a12-a286-16817c0261b8">
### How Has This Been Tested?
This has been tested using a local machine on Ubuntu 22.04 with a simulator deployed. The project builds locally and the ui passes `npm run test:unit`.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow users to add description to private gateway [cloudstack]
Posted by "charlesweng (via GitHub)" <gi...@apache.org>.
charlesweng commented on PR #9135:
URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-2259006456
@DaanHoogland took a look at the code and I think the title of the issue and the PR was misleading with the static routes as there are static routes in both the UI and the backend. Here is the change for static routes in the backend:
[api/src/main/java/com/cloud/network/vpc/StaticRouteProfile.java](https://github.com/apache/cloudstack/pull/9135/files#diff-ce3a0b58c13a72aa9200b029ae8507c0e408877ce45a40940dee7fb99620659eR32-R110)
I still need to test and see if this branch works without UPDATE: planning to remove description in network classes only keeping in vpc classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow users to add description to private gateway and static routes [cloudstack]
Posted by "charlesweng (via GitHub)" <gi...@apache.org>.
charlesweng commented on PR #9135:
URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-2145218338
@DaanHoogland thank you so much for responding. I added several changes in the commit - [createprivatenetwork methods,*cmd.java, and many other classes](https://github.com/apache/cloudstack/pull/9135/commits/a524059032ca24b0b8c9842ea5dc31a9fc30dd5e). However, I may have missed something like you said. I will convert this pull request to draft and take a closer look and give you more screen shots!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow users to add description to private gateway [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #9135:
URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-5269115519
Hi @charlesweng is this PR ready for review or is it still in progress?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow users to add description to private gateway and static routes [cloudstack]
Posted by "charlesweng (via GitHub)" <gi...@apache.org>.
charlesweng commented on PR #9135:
URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-2137882691
closing, someone has already started working on this feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow users to add description to private gateway and static routes [cloudstack]
Posted by "charlesweng (via GitHub)" <gi...@apache.org>.
charlesweng commented on PR #9135:
URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-2143675128
Reopening - looking into this again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow users to add description to private gateway [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #9135:
URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-2283768559
> @DaanHoogland took a look at the code and I think the title of the issue and the PR was misleading with the static routes as there are static routes in both the UI and the backend. Here is the change for static routes in the backend:
>
> [api/src/main/java/com/cloud/network/vpc/StaticRouteProfile.java](https://github.com/apache/cloudstack/pull/9135/files#diff-ce3a0b58c13a72aa9200b029ae8507c0e408877ce45a40940dee7fb99620659eR32-R110)
>
> I still need to test and see if this branch works without UPDATE: planning to remove description in network classes only keeping in vpc classes
thnx @charlesweng , I am marking this as draft untill you are done. You can mark it as ready at your will.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow users to add description to private gateway [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9135:
URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-3682099944
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow users to add description to private gateway and static routes [cloudstack]
Posted by "charlesweng (via GitHub)" <gi...@apache.org>.
charlesweng closed pull request #9135: allow users to add description to private gateway and static routes
URL: https://github.com/apache/cloudstack/pull/9135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow users to add description to private gateway and static routes [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #9135:
URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-2167308425
> @DaanHoogland will look into the lint errors in sql file and double check if description is needed in network, but VPCGateway description is definitely needed, thanks!
Yes @charlesweng the VPCGateway looks good. What I wonder about is the mention of static routes in the description of this PR. I see no change for those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow users to add description to private gateway and static routes [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #9135:
URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-2144774814
@charlesweng , one question: in your description you speak about adding descriptions to Proutes, but in the code I only see the value object (VO) for network being changed. Can you explain what the plan is here, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow users to add description to private gateway and static routes [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #9135:
URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-2162857472
@charlesweng , I reviewed your changes and am still a bit confused. The changes look good but they seem to add descriptions to `VpcGateway`s and `Network`s but not to static routes. Is the ttile of the PR misleading or are you not done yet?
btw, you have a lint error because of an EOF not being preceeded by an EOL in the sql file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow users to add description to private gateway and static routes [cloudstack]
Posted by "charlesweng (via GitHub)" <gi...@apache.org>.
charlesweng commented on PR #9135:
URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-2166217020
@DaanHoogland will look into the lint errors in sql file and double check if description is needed in network, but VPCGateway description is definitely needed, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow users to add description to private gateway and static routes [cloudstack]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #9135:
URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-2135961649
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:
- In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
- Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
- Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
- Please follow [ASF Code of Conduct](https://github.com/apache/.github/blob/main/.github/CODE_OF_CONDUCT.md) for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
- Be sure to read the [CloudStack Coding Conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions).
Apache CloudStack is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
Slack: https://apachecloudstack.slack.com/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow users to add description to private gateway and static routes [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #9135:
URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-2136067465
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9135?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.25%. Comparing base [(`e817e04`)](https://app.codecov.io/gh/apache/cloudstack/commit/e817e04343a3c91696625211b59d916125366fc1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`a524059`)](https://app.codecov.io/gh/apache/cloudstack/commit/a524059032ca24b0b8c9842ea5dc31a9fc30dd5e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 18 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #9135 +/- ##
============================================
- Coverage 15.28% 4.25% -11.03%
============================================
Files 5425 363 -5062
Lines 474157 29686 -444471
Branches 59121 5214 -53907
============================================
- Hits 72479 1264 -71215
+ Misses 393612 28279 -365333
+ Partials 8066 143 -7923
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9135/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9135/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.25% <ø> (-0.02%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9135/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9135?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow users to add description to private gateway [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #9135:
URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-3645621138
@charlesweng , are you still interested in moving this forwards?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org