You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/25 10:28:55 UTC
[GitHub] [arrow-rs] alamb commented on a diff in pull request #3189: Add sleep to object_store CI
alamb commented on code in PR #3189:
URL: https://github.com/apache/arrow-rs/pull/3189#discussion_r1032256679
##########
.github/workflows/object_store.yml:
##########
@@ -86,6 +86,7 @@ jobs:
- name: Configure Fake GCS Server (GCP emulation)
run: |
docker run -d -p 4443:4443 fsouza/fake-gcs-server -scheme http
+ sleep 1
Review Comment:
```suggestion
# Give the container a moment to start up prior to configuring it
sleep 1
```
##########
.github/workflows/object_store.yml:
##########
@@ -86,6 +86,7 @@ jobs:
- name: Configure Fake GCS Server (GCP emulation)
run: |
docker run -d -p 4443:4443 fsouza/fake-gcs-server -scheme http
+ sleep 1
Review Comment:
We could also always do the classic loop until success with timeout -- but I think the sleep idea initially is much simpler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org